Text Mining Project: Sentiment Analysis for the Presidential Candidates#9
Open
awu1 wants to merge 9 commits intosd16fall:masterfrom
Open
Text Mining Project: Sentiment Analysis for the Presidential Candidates#9awu1 wants to merge 9 commits intosd16fall:masterfrom
awu1 wants to merge 9 commits intosd16fall:masterfrom
Conversation
added 9 commits
September 30, 2016 19:48
branchwelder
reviewed
Oct 4, 2016
branchwelder
left a comment
branchwelder
left a comment
There was a problem hiding this comment.
I made one main comment for my feedback.
| @@ -0,0 +1,111 @@ | |||
| { | |||
There was a problem hiding this comment.
Overall, good job!
A few comments:
- In the future, please upload a .py file instead of a Jupyter notebook, as it's much easier for us to read and critique.
- Small thing: Try to be consistent with your spacing. In between functions, you should generally have 2 lines of space.
- When you do have a Jupyter Notebook, be sure to run all cells before pushing to github, because then we can see all of your output. (I can't see the plot you made, but it looks like you attached it elsewhere so you're all good)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.