Fix distorted rendering on PSVR2.#134
Open
s-ilent wants to merge 1 commit intosd805:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent a while debugging and testing this and it seems to work fine, but I can't test on other headsets and I am also not super familiar with OpenVR.
Essentially, on PSVR2, rendering is incorrect using the raw values provided by the driver. This is only a little uncomfortable to look at, and is mainly noticeable on weapons.
Originally, I thought the issue was that the viewmodels weren't being transformed correctly due to some quirk of the PSVR2 controller position, but it turns out the whole view is stretched vertically. You can see it in screenshots.
With this change, there is no stretching.
This change adjusts the vertical tangent to match the aspect ratio of the render texture. Changing the render texture size also works, but breaks post-effects like the pause menu blur.