Conversation
…ed points Fixes: #32
106db3a to
865b3b7
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #301 +/- ##
===========================================
- Coverage 94.88% 81.34% -13.54%
===========================================
Files 54 70 +16
Lines 5705 14689 +8984
Branches 5705 14689 +8984
===========================================
+ Hits 5413 11949 +6536
- Misses 274 2651 +2377
- Partials 18 89 +71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
087f701 to
3535246
Compare
… Add some asm hooks
5737793 to
393db32
Compare
9f4cfe8 to
0e3fc9b
Compare
0e3fc9b to
fc64933
Compare
060943f to
8021d75
Compare
e15e9c0 to
ba65bc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to introduce the first alpha of Kiddo 6. 10 months in the making and counting, it is effectively a full rewrite, addressing some long-standing issues.
KdTreestruct, replacing the previous mutable/immutable and float/fixed splits.KdTreehas as a generic property. LeafStrategies can be mutable or immutable.KdTreeis also now generic over the new StemStrategy trait too. This allows experimentation and selection of alternative stem layouts and traversal mechanisms, orthogonal to the choice of leaf strategy.At the moment v6 is still not quite ready for production use cases but I'm hoping to release it soon as an alpha so that people are able to try it out if interested and provide feedback, bug reports, and performance reports, to help get it to the point where it is production-ready. I'll be updating the benchmarking suite too with results from v6, as well as updating the stale results from other libraries to use their latest versions. I may add some new libraries against which to run the benchmarks too (suggestions welcome).