Skip to content

Conversation

@TheMythologist
Copy link

Closes #241

@canihasreview
Copy link

canihasreview bot commented Oct 25, 2025

Click here to submit a new iteration when this PR is ready for review.

See this repository's contribution guide for more information.

@canihasreview
Copy link

canihasreview bot commented Oct 25, 2025

v1

@TheMythologist submitted v1 for review.

(📚 Archive)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level3.git refs/pr/242/1/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

@damithc
Copy link
Contributor

damithc commented Oct 26, 2025

Thanks for this PR, @TheMythologist
We are likely to look into this after this semester is over. In the meantime, please submit a new version with a detailed commit message -- in AB3, we normally use a detailed commit message with a body (see https://se-education.org/guides/conventions/git.html)

@codecov
Copy link

codecov bot commented Oct 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.28%. Comparing base (bd6718b) to head (8168ef1).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #242      +/-   ##
============================================
+ Coverage     75.26%   75.28%   +0.01%     
  Complexity      419      419              
============================================
  Files            71       71              
  Lines          1338     1339       +1     
  Branches        126      126              
============================================
+ Hits           1007     1008       +1     
  Misses          301      301              
  Partials         30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deserializing into generic classes

2 participants