Add ParserConfig accessors, convenience methods, and request parsing options#159
Open
tgnottingham wants to merge 6 commits intoseanmonstar:masterfrom
Open
Add ParserConfig accessors, convenience methods, and request parsing options#159tgnottingham wants to merge 6 commits intoseanmonstar:masterfrom
ParserConfig accessors, convenience methods, and request parsing options#159tgnottingham wants to merge 6 commits intoseanmonstar:masterfrom
Conversation
Author
|
Hi @seanmonstar, sorry to ping, but do you think there are any deal-breakers with the concept of this PR? The purpose was mainly to add parsing options that were present for responses but missing for requests ( I could see the addition of the methods that configure request parsing and response parsing simultaneously being undesirable, for example, and I can remove if so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing
ParserConfigaccessors, convenience methods for configuring request and response parsing simultaneously, and request parsing options that bring request parsing configuration up to parity with response parsing configuration.