Resize headers on partial parse#160
Open
tgnottingham wants to merge 1 commit intoseanmonstar:masterfrom
Open
Conversation
The main benefit of this is that it enables you to get the parsed headers from partial results when using uninitialized headers. Prior to this, on a partial result, the headers in a request or response would be replaced with the original slice passed when creating the request or response (typically an empty slice when using uninitialized headers), rather than the initialized portion of the uninitialized headers passed into the parse function call. It also makes handling partial parse results more convenient in general since you can iterate over the headers in the request or response without having to manually determine the last element. This is technically a breaking change, though it seems unlikely that any client would depend on the previous behavior in a way that the change would break their code.
Author
|
I realized that there is a use case where a client might have depended on the previous behavior -- repeatedly using the same Request/Response until the result is Complete. With this change, if a later parse input has more header fields than a previous input, it will result in a TooManyHeaders error because the previous partial parse shrunk the headers. Of course, even without my change, Complete Requests/Responses can't be reused for the exact same reason. Still, I'm guessing the change in behavior in the Partial case is enough to dissuade accepting this PR. Bummer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main benefit of this is that it enables you to get the parsed headers from partial results when using uninitialized headers. Prior to this, on a partial result, the headers in a request or response would be replaced with the original slice passed when creating the request or response (typically an empty slice when using uninitialized headers), rather than the initialized portion of the uninitialized headers passed into the parse function call.
It also makes handling partial parse results more convenient in general since you can iterate over the headers in the request or response without having to manually determine the last element.
This is technically a breaking change, though it seems unlikely that any client would depend on the previous behavior in a way that the change would break their code.