Feature/chat : kafka 설정, 채팅 기능, 채팅방 생성/삭제 기능 구현#2
Merged
KindNeighbor merged 7 commits intodevelopfrom Feb 9, 2023
Merged
Conversation
Contributor
|
채팅방 생성시 컨트롤러 부분에다가 PathVariable로 theater_id를 받았습니다. 처음에는 RequestParam으로 할까 하다가 값이 하나라서 그냥 @PathVariable로 넣었습니다. 어떤게 나은가요??
kafka 관련 파일들의 경우 Configuration 하나, Component 하나, Service 하나 있어서 그냥 한 패키지에 넣어버리고 config 패키지에 두었습니다. 혹시 다르게 나누고 싶은 의견이 있다면 알려주세요.
pr 템플릿이 없더라구요. pr 전 커밋으로 넣어놓을까요??
|
Contributor
Author
변경 사항
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경사항
📌 AS-IS
📌 TO-BE
잘 봐주었으면 하는 부분
수정할 것 있으면 전부 말해주세요.
테스트
테스트는 로직 확정되면 바로 하겠습니다.