BUG: fix 54-live-binary_tree to use binary tree

[kolyshkin]

Apparently, an early implementation of the binary tree optimization
used to enable the feature when the number of rules added was > 16.

The code was later changed to add and use SCMP_FLTATR_CTL_OPTIMIZE,
but the 54-live-binary_tree test case was left as is. So, despite
its name, it is not testing the binary tree.

Fix this, and remove the comment that referred to the old
implementation.

Fixes: 38f04da (PR #152)
Signed-off-by: Kir Kolyshkin kolyshkin@gmail.com

[kolyshkin]

Seems that CI is screwed because of an inconsistent state of Azure's Ubuntu apt mirror, e.g.

E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/g/glibc/libc6-dbg_2.31-0ubuntu9.2_amd64.deb 404 Not Found [IP: 40.81.13.82 80]

[drakenclimber]

Seems that CI is screwed because of an inconsistent state of Azure's Ubuntu apt mirror, e.g.

E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/g/glibc/libc6-dbg_2.31-0ubuntu9.2_amd64.deb 404 Not Found [IP: 40.81.13.82 80]

I re-kicked off the CI. Fingers crossed.

[drakenclimber]

Looks good to me. Thanks @kolyshkin.

Reviewed-by: Tom Hromatka <tom.hromatka@oracle.com>

[pcmoore]

I just kicked the CI too as the last run was still failing with the same problem.

[pcmoore]

Oh, I found the CI problem, just a minute ...

[pcmoore]

Okay, our CI should now be fixed (we we're missing an apt-get update to ensure our apt repo metadata wasn't stale) in 7a28dfa or later. @kolyshkin would you mind rebasing your PR against the new libseccomp/main branch? If that's a problem let me know and I'll just review/test it against the updated main.

@drakenclimber since this was a trivial change and we needed it to get the CI working again I just went ahead and merged the fix, if you have any concerns about it let me know and we can patch over it or revert it if something is really wrong.

[drakenclimber]

@drakenclimber since this was a trivial change and we needed it to get the CI working again I just went ahead and merged the fix, if you have any concerns about it let me know and we can patch over it or revert it if something is really wrong.

Totally the right thing to do. No objections here.

[kolyshkin]

Okay, our CI should now be fixed (we we're missing an apt-get update to ensure our apt repo metadata wasn't stale)

Ah! I briefly suspected that yesterday but neglected to check :-\

would you mind rebasing your PR against the new libseccomp/main branch

Done

[coveralls]

Coverage remained the same at 89.601% when pulling 9779813 on kolyshkin:tests-54-tfix into 7a28dfa on seccomp:main.

[pcmoore]

Merged via 5731b3c and 861e2dc, thanks!