Conversation
|
Thanks for this huge pr!
If you don't have much time, then just split the random formatting changes from the js->tsx refactor plz. Ideally would be better to make the changes to js files as a rename, and not as a deletion and addition. According to this the best strategy is to first rename them in a commit and then apply the content changes. If you don't have time for the things above, just make the tests pass and I will try to do the rest :) |
|
Actually I've done a single commit because I wanted to make it at least build, I don't like broken commits. Unfortunately it was pretty difficult to move between compiling states without making a mess. If you want splitted commits I can do it, but it's still a WIP, I wanted to fix more things before merging the PR. Right now the frontend code it's in a state of insanity to be honest (and it was even worse before 😅). The test are failing apparently because of a python server error that I didn't touch, can you give me any help? |
|
Does it "compile" for you? |

Closes #32