-
Notifications
You must be signed in to change notification settings - Fork 2
Add pipeline command #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
|
I can repro this, I'll report back when I figure out what's going on! |
|
I think I've found some clues to the error. The pose of a Space gets added as part of the processors once the model is parsed: Those processors are added when we register the language: Possibly the cause is that we need to temporarily remove the processors to generate the variations (where we need the abstract syntax and not the concrete values): I changed the base to |
This should solve the issues in secorolab/scenery_builder#35
| required=True, | ||
| help="Path to the .variation model file", | ||
| ) | ||
| @click.option( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it would be possible to not duplicate the args in the pipeline command. I can't remember the specifics when I was testing a single command, but my suggestion if you have time to test would be:
- Move the config arg from the
generatecommand tofloorplan - Check what is available inside
ctx.default_mapwhen you call it from the other commands. I vaguely remember you might need to access a parentctxto get what is read from the config, at least for the current implementation. - Change it so that it a) propagates down to the correct
ctxof the child commands, or access it from the parentctx(only) for thepipelinecommand
| ) | ||
| ) | ||
|
|
||
| # Build graph from the JSON-LD directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid duplicating code here and call the respective commands instead
add pipeline command :
But it currently fails with
Manually running the three steps succeeds. Maybe the error is related to parts of the app being initialized wrongly after the first step.
What is also working: