Skip to content

Consume solver results #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MMory merged 3 commits into from
Apr 20, 2023
Merged

Consume solver results #608

MMory merged 3 commits into from
Apr 20, 2023

Conversation

@fabianbs96
Copy link
Member

@fabianbs96 fabianbs96 commented Apr 3, 2023

The IDESolver has been found to consume a lot of memory, most of it being intermediate results.

This PR aims at reducing the total memory overhead with two contributions:

  1. The default solver configuration no longer enables recording the ESG edges in an additional map (this feature is anyway likely to be deprecated and replaced in the future). This has to be enabled explicitly. Note: phasar-cli already disables recordEdges by default
  2. The solver results can be moved out of the IDESolver. This allows destructing the solver while retaining the solver results for subsequent analysis. To simplify the process new functions solveIDEProblem and solveIFDSProblem have been added

@fabianbs96 fabianbs96 requested a review from MMory as a code owner April 3, 2023 16:25
@fabianbs96 fabianbs96 self-assigned this Apr 3, 2023
@fabianbs96 fabianbs96 added the enhancement New feature or request label Apr 3, 2023
MMory
MMory approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@MMory MMory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@MMory MMory merged commit 290f455 into development Apr 20, 2023
@MMory MMory deleted the f-ConsumeSolverResults branch April 20, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MMory MMory MMory approved these changes

Assignees

@fabianbs96 fabianbs96

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fabianbs96 @MMory