Phasar DynLib and LTO #621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianbs96
requested review from
MMory and
janniclas
and removed request for
MMory
MMory
reviewed
May 31, 2023
Member
MMory
left a comment
MMory
left a comment
There was a problem hiding this comment.
Would be good to have a hint somewhere that makes people include their newly added header(s) to the directory include headers. Coding guidelines?
Member
|
@vulder does this break vara? just wanna make sure it doesn't before we merge, adding a block for this. |
MMory
added
the
blocked
vulder
approved these changes
Jun 5, 2023
Collaborator
vulder
left a comment
vulder
left a comment
There was a problem hiding this comment.
From a comparability standpoint, this works for us.
PS: I did not fully check the rest of the PR, just if it works in our in-tree setup. 👍
fabianbs96
removed
the
blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhASAR 's codebase is growing continuously which makes it harder for externals to keep an overview, e.g. which libraries should be linked against, which headers to include (and where to find them).
This PR adds convenience headers that include every header from a particular subdirectory (plus one that includes whole phasar).
Additionally, phasar now builds a large library
libphasar.a/libphasar.soby default that can be linked against.The smaller "component-wise" libraries are still there for a more optimized build.