-
Notifications
You must be signed in to change notification settings - Fork 156
Lock-step Solving and Timeout for IDE Solver #638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MMory
reviewed
Jun 29, 2023
MMory
approved these changes
Jun 29, 2023
Member
MMory
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, it is good to have this, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
solve()method on theIDESolvercannot be interrupted once started. This is not problem for analyzing small target programs, but is unacceptable for larger analyses that may run for days.This PR adds fine-grained control over the solving process while still abstracting the solver internals.
The abstraction consists of three basic functions:
initialize,nextandfinalize.They are being called according to the below flow-chart:
In addition to these basic APIs there are convenience functions like
solveUntil,solveWithTimeout, etc. that build upon this model.The original
solvemethod has been rewritten and makes use of this model as well while keeping its original semantics.Further, the solving methods (including
finalize) now return a view into the solver results (or owning solver-results when called with an rvalue-reference) for allowing to be used in a more fluent way.