F clang tidy compliance #641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poppeldipop
requested review from
MMory,
fabianbs96,
pdschubert and
vulder
as code owners
fabianbs96
reviewed
Jul 6, 2023
Member
fabianbs96
left a comment
fabianbs96
left a comment
There was a problem hiding this comment.
Looks good to me, except minor; thanks!
Comment on lines
4
to
9
| #ifndef PHASAR_UTILS_MEMORYRESOURCE_H | ||
| #if !defined(__has_include) || __has_include(<memory_resource>) | ||
| #define HAS_MEMORY_RESOURCE 1 | ||
| #define PHASAR_UTILS_MEMORYRESOURCE_H 1 | ||
| #include <memory_resource> | ||
| #else | ||
| #define HAS_MEMORY_RESOURCE 0 | ||
| #define PHASAR_UTILS_MEMORYRESOURCE_H 0 |
Member
There was a problem hiding this comment.
This is no include guard. Please revert
fabianbs96
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have addressed some Clang-tidy warnings