Improve Logger Performance #683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MMory
approved these changes
Nov 24, 2023
Member
MMory
left a comment
MMory
left a comment
There was a problem hiding this comment.
lgtm, as discussed recently, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
IF_LOG_ENABLEDmacro only checks for the logger being enabled, not for the enabled log level. This leads to drastical performance drops in the IDESolver when enabling logging -- even if just INFO log is enabled.This PR fixes this issue by providing a new macro
IF_LOG_LEVEL_ENABLEDthat additionally checks for the enabled log level.Additionally, the logger is slightly refactored