Skip to content

Fix Linking for LLVMBasedICFGGlobCtorDtorTest #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MMory merged 2 commits into from
Dec 12, 2023
Merged

Fix Linking for LLVMBasedICFGGlobCtorDtorTest #692

MMory merged 2 commits into from
Dec 12, 2023

Conversation

@fabianbs96
Copy link
Member

@fabianbs96 fabianbs96 commented Dec 11, 2023

@fabianbs96
The LLVMBasedICFGGlobCtorDtorTest needs LLVMLinker, so we better link…
9b1033e 
… explicitly, instead of relying on transitive linkage
@fabianbs96 fabianbs96 added the bug Something isn't working label Dec 11, 2023
@fabianbs96 fabianbs96 self-assigned this Dec 11, 2023
@fabianbs96 fabianbs96 requested a review from MMory as a code owner December 11, 2023 18:01
@fabianbs96 fabianbs96 changed the title Fix LInking for LLVMBasedICFGGlobCtorDtorTest Fix Linking for LLVMBasedICFGGlobCtorDtorTest Dec 11, 2023
MMory
MMory approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@MMory MMory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@MMory MMory merged commit c3f5591 into development Dec 12, 2023
@MMory MMory deleted the f-FixUnittestNeedsLinker branch December 12, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MMory MMory MMory approved these changes

Assignees

@fabianbs96 fabianbs96

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fabianbs96 @MMory