Skip to content

Conversation

@fabianbs96
Copy link
Member

Do not install phasar's dependencies to the global namespace anymore.

#566

@fabianbs96 fabianbs96 added dependencies Pull requests that update a dependency file technical debt labels Mar 4, 2024
@fabianbs96 fabianbs96 self-assigned this Mar 4, 2024
@fabianbs96 fabianbs96 marked this pull request as ready for review March 8, 2024 17:49
@fabianbs96 fabianbs96 requested a review from MMory as a code owner March 8, 2024 17:49
Copy link
Member

@MMory MMory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@fabianbs96 fabianbs96 merged commit 8052296 into development Mar 13, 2024
@fabianbs96 fabianbs96 deleted the f-DependencyInstallation branch March 13, 2024 20:10
mxHuber pushed a commit to fabianbs96/phasar that referenced this pull request Mar 24, 2024
* Do not install phasar's dependencies to the global namespace anymore

* fix for in-tree build

* out-factor the inclusion of LLVM and clang to a separate cmake file

* Make PHASAR_CONFIG_INSTALL_DIR respect the CMAKE_INSTALL_PREFIX, even if that is not set at configure time

* Fix in-tree build
fabianbs96 added a commit that referenced this pull request Oct 22, 2024
* unresolved ref to F/NToString

* compiles

* refactored CallGraph::deserialize()

* refactored unittests, all fail

* all unittests finally pass

* code cleanup

* refactoring

* fixed function with no caller not being serialized

* Fix Dependendency Installation (#707)

* Do not install phasar's dependencies to the global namespace anymore

* fix for in-tree build

* out-factor the inclusion of LLVM and clang to a separate cmake file

* Make PHASAR_CONFIG_INSTALL_DIR respect the CMAKE_INSTALL_PREFIX, even if that is not set at configure time

* Fix in-tree build

* backup DIBTH Data

* DIBTH serialization code, untested

* DIBTHData getDataFromJson Impl

* improved de-/serialization impl w/o TypeToVertex

* fixed DIBTHData TypeToVertex not compiling

* fixed serialization bugs and unittests

* DITHS Test fixes, 13 pass, 11 fail

* DIBTH Ser Test, 1 failing Test left

* GeneralStatisticsAnalysisData impl

* LLVMAliasSetData impl

* last printAsJson Impls

* Final Impls, DIBTH Identifier Impl not working

* changes + fixes from meeting

* no equality of values DIBTH Test

* fixed all bugs, all unittests pass

* Fix crash in buildTypeGraph in the presence of typedefs

* fixed LLVMAliasSetSerializationTest

* Add more aggressive composite type filter

* Refactor handling of DI type names

* Implicit vertex index

* Prioritize type id over type name as the latter may be ambiguous

* Adapt DI TH test to identifiers as names

* Fix vtable + transitive di th tests

* Optimizing deprecation warnings for getAsJson

* TypeTrait check current non functioning impl

* fixed TypeHierarchySerialization Tests

* Optimized deprecation warinings for getAsJson

* debug code backup

* Fix LLVMBasedTypeHierarchy

* added operator<< statistics to printAsJson

* Fix GeneralStatistics printAsJson + minor

* Add some more deprecations

* Fix now failing unittests

* Changes from review

---------

Co-authored-by: mxHuber <huber.maximilian.leo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants