Improve phasar as subdirectory experience #708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… so that users do not clone it multiple times when use recursive cloning
MMory
approved these changes
Mar 11, 2024
Member
MMory
left a comment
MMory
left a comment
There was a problem hiding this comment.
looks good to me! I wasn't really aware of the FetchContent feature, cool stuff! At some point we might wanna bump the cmake version we require, we haven't done so in a while
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhASAR is recommended to be pulled in via
add_subdirectoryin cmake. However, there are many small things to improve in this scenario, mostly by excluding targets that are unneeded by clients.Additionally, phasar can then also better be used via FetchContent
We now also use FetchContent to pull in GoogleTest instead of including it as a submodule.
This avoids users to pull it in accidentally multiple times