Call-Graph Improvements #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llGraphAnalysisType
sritejakv
approved these changes
Sep 8, 2025
Collaborator
sritejakv
left a comment
sritejakv
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks.
fabianbs96
merged commit 1e857b1
into
secure-software-engineering:development
8 checks passed
mxHuber
pushed a commit
to fabianbs96/phasar
that referenced
this pull request
Oct 17, 2025
* minor fix in CHA and RTA resolvers * Several small improvements for call-graph resolving * Fix out-of-bounds access in getVarTypeFromIR() * Add address-taken functions caching in base resolver * Some cleanup in resolvers * pre-commit * Fix bug in the overloads of buildLLVMBasedCallGraph() that takes a CallGraphAnalysisType
fabianbs96
added a commit
that referenced
this pull request
Nov 8, 2025
* added test coverage for ci * merged coverage job into build, removed all but one step for testing * test code for meeting * Call-Graph Improvements (#785) * minor fix in CHA and RTA resolvers * Several small improvements for call-graph resolving * Fix out-of-bounds access in getVarTypeFromIR() * Add address-taken functions caching in base resolver * Some cleanup in resolvers * pre-commit * Fix bug in the overloads of buildLLVMBasedCallGraph() that takes a CallGraphAnalysisType * Dbg-Info based Type Matching (#791) * moved stripPointerTypes() + debug prints * MetadataKind approach * I think we don't get around using getName() * unittests still fail * bugfix + cleanup * Some cleanup * Implement allocated-types collection in terms of debug info * Fix libdeps * Remove some unneeded includes --------- Co-authored-by: Fabian Schiebel <52407375+fabianbs96@users.noreply.github.com> Co-authored-by: Fabian Schiebel <fabian.schiebel@iem.fraunhofer.de> * Some fixes in the IterativeIDESolver (#782) * Fix the IterativeIDESolver by allowing to analyze problems that override extend() and combine() * Use the logger in the IterativeIDESolver * Make it possible to solve the IDEFeatureTaintAnalysis with the IterativeIDESolver * Fix errors introduced by merge * Bump dependencies (#784) * Remove boost from BitVectorSet (#788) * Remove boost from BitVectorSet * Minor deboostifying * Apply review comment on Bit-index-inbounds check + simplify operator<< * GCC Compatibility (#787) * Make phasar compile with gcc (g++-11) and uncover (and fix) two bugs related to json ser/de with LLVMAliasSet and LLVMBasedICFG that were not detected untio now, because of nlohmann's implicit conversions feature * Address review comments * Simplify isLLVMZeroValue according to the discussion in #787 * backup for rebase * cmake works, g++ fails * working version (with local hacks -20) * added regex for filter, it is not working * fixed filtering + cleanup * basic ci impl, lib coverage, fixed release cmake error * added cmake-scripts to submodule index * set llvm-cov before code-cov script * fixed version of llvm-cov * testing v19 due to ci issues * testing cov only when in debug build type * fixed all build type checks * added -v to see invocation of error in ci * only run coverage when matrix.build is Debug * Debug code + potential bug found? * only run cov when PHASAR_DEBUG_LIBDEPS is off * removed debug code, added messages for cov paths * testing llvm cov 19 * hardcoded llvm-19 for cov * adding llvm-19 as dependency for cov tools * disabling asan for release for now * removed unneccesary char * development merge + json external * Is the sanitizer the problem? * fixed cmake failing when in debug w/o -DCODE_COVERAGE=ON * added coverage report artifact uploading * fixed ci * fixed filtering not working correctly on runner * docker sanitizer back ON + new matrix entry DebugCov * Docker sanitizer still fails, disabling for now * Removed coverage of unittests * cleanup * Some cleanup * Add demangling to cov report * artifact should be entire all-merged/ folder * external diff * removed rename of index.html * Revert json downgrade --------- Co-authored-by: Fabian Schiebel <52407375+fabianbs96@users.noreply.github.com> Co-authored-by: Fabian Schiebel <fabian.schiebel@iem.fraunhofer.de> Co-authored-by: Fabian Schiebel <fabianbs@mail.upb.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of smaller changes related to call-graph resolvers