feat: add tmdb- and imdb link on person detail page#2096
Closed
bogo22 wants to merge 2 commits intoseerr-team:developfrom
bogo22:personal-details-links
Closed
feat: add tmdb- and imdb link on person detail page#2096bogo22 wants to merge 2 commits intoseerr-team:developfrom bogo22:personal-details-links
bogo22 wants to merge 2 commits intoseerr-team:developfrom
bogo22:personal-details-links
Conversation
gauthier-th
reviewed
Oct 28, 2025
Comment on lines
+36
to
+39
| const isMovie = mediaType === MediaType.MOVIE; | ||
| const isTv = mediaType === MediaType.TV; | ||
| const isPerson = mediaType === 'person'; | ||
| const imdbType = isPerson ? 'name' : 'title'; |
Member
There was a problem hiding this comment.
Not really a big fan of creating dedicated variables to store very simple checks used only once.
Contributor
Author
There was a problem hiding this comment.
Got it, will replace the checks in-place and remove the variables.
This commit adds links to tmdb and imdb on the person detail page Signed-off-by: Florian Hoech <code@florians-web.de>
fallenbagel
approved these changes
Oct 29, 2025
Contributor
Author
|
Thanks for the review. Is there anything left on my side? If yes, please let me know. Much thanks. |
Contributor
Nope nothing to do on your side. We just won't merge it now as we are in a feature freeze mode until the merger is complete. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit adds links to tmdb and imdb on the person detail page.
To-Dos
pnpm buildpnpm i18n:extractScreenshot (if UI-related)