feat: modernize core dependencies (Node 24, React 19, Next 16, Tailwind 4)#2631
feat: modernize core dependencies (Node 24, React 19, Next 16, Tailwind 4)#2631dutch2005 wants to merge 3 commits intoseerr-team:developfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds a new GitHub Actions "Main Pipeline" workflow, removes three Husky commit hooks, adds policy doc about disallowing TypeScript build-error suppression, and relaxes the Node.js engine constraint in package.json to ">=22.0.0". Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer (push/PR)
participant GH as GitHub Actions (Main Pipeline)
participant Repo as Repository
participant Node as Node/pnpm Environment
participant Audit as Security Audit
participant Jules as Jules PR Guard
participant Test as Test/Build Steps
Dev->>Repo: push or open PR
Repo->>GH: trigger workflow
GH->>Node: setup Node 22 & pnpm 10
GH->>Repo: checkout code
GH->>Node: install deps (frozen lockfile)
GH->>Audit: run pnpm security audit
GH->>Jules: run Jules PR Guard (conditional on PR content)
GH->>Node: run lint (if-present)
GH->>Test: run unit tests and production build (if-present)
Test-->>GH: build/test results
GH-->>Repo: publish workflow status
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dutch2005
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (1)
.github/workflows/main-pipeline.yml (1)
3-7: Workflow triggers may not align with PR target branch.The workflow triggers on
mainandmasterbranches, but according to the PR objectives, this PR targets thedevelopbranch. The workflow won't run for PRs targetingdevelop, potentially leaving changes unvalidated until merged to main.Consider adding
developto the trigger branches if CI validation is intended for feature PRs.🔧 Proposed fix
on: push: - branches: [ "main", "master" ] + branches: [ "main", "master", "develop" ] pull_request: - branches: [ "main", "master" ] + branches: [ "main", "master", "develop" ]🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/main-pipeline.yml around lines 3 - 7, The workflow currently triggers only on push and pull_request for branches ["main","master"]; update the on.push.branches and on.pull_request.branches arrays to include "develop" so CI runs for PRs targeting develop; locate the on: block in the GitHub Actions config where branches are defined and add "develop" alongside "main" and "master" (preserve YAML array format and quoting).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/main-pipeline.yml:
- Around line 32-33: The CI step named "Install Dependencies" currently runs
"pnpm install --no-frozen-lockfile", which permits the lockfile to be modified
during CI; update that step to use a locked install by removing the
"--no-frozen-lockfile" flag or replacing it with "--frozen-lockfile" so the job
fails if pnpm-lock.yaml is out of sync, ensuring reproducible, reviewable
dependency installs.
- Around line 21-24: CI uses actions/setup-node@v4 with node-version: 20 which
conflicts with package.json's "node": ">=22.0.0" and .npmrc engine-strict=true;
update the workflow step that uses actions/setup-node@v4 to specify
node-version: 22 (or a version range matching package.json) so the Node runtime
in the pipeline satisfies the declared engines and pnpm install won't fail.
- Around line 38-40: The workflow step named "Jules PR Guard (Strict Quality
Check)" is invoking a non-existent script (`pnpm type-check`); update that step
to call the correct script name `pnpm typecheck` (match the package.json script
"typecheck") so the CI job runs the actual typecheck task.
- Around line 26-30: Update the GitHub Actions step that currently uses
"pnpm/action-setup@v3" in the "Setup pnpm" job to the v4 release (e.g.,
"pnpm/action-setup@v4" or pin to "pnpm/action-setup@v4.2.0") so the workflow
uses the current stable action compatible with pnpm 10; modify the uses value
for the "Setup pnpm" step accordingly and keep existing inputs (version: 10,
run_install: false) unchanged.
In @.jules/bolt.md:
- Around line 1-4: The policy references a non-existent script name "pnpm
type-check" while package.json defines "typecheck"; update the policy text to
use the actual script name "pnpm typecheck" or add an alias script "type-check"
to package.json so both commands work; locate the policy entry in .jules/bolt.md
and the scripts section in package.json (search for "typecheck") and make the
change so the command names are consistent across docs and package scripts.
---
Nitpick comments:
In @.github/workflows/main-pipeline.yml:
- Around line 3-7: The workflow currently triggers only on push and pull_request
for branches ["main","master"]; update the on.push.branches and
on.pull_request.branches arrays to include "develop" so CI runs for PRs
targeting develop; locate the on: block in the GitHub Actions config where
branches are defined and add "develop" alongside "main" and "master" (preserve
YAML array format and quoting).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e2c53aa6-3a7b-45a4-9f68-4a53e75f4d9a
📒 Files selected for processing (6)
.github/workflows/main-pipeline.yml.husky/commit-msg.husky/pre-commit.husky/prepare-commit-msg.jules/bolt.mdpackage.json
💤 Files with no reviewable changes (3)
- .husky/commit-msg
- .husky/pre-commit
- .husky/prepare-commit-msg
This change adds a 'Markdown Support' toggle to ntfy settings and sends the 'X-Markdown: yes' header when enabled, as requested in seerr-team#2631.
|
👋 @dutch2005, thank you for your contribution! |
2 participants
Title:
feat: Modernize core dependencies (Node 24, React 19, Next 16, Tailwind 4)Description:
[next] Creating an optimized production build ...
[next] Compiled successfully.
[next] Collecting page data ...
[next] Generating static pages (0/15) ...
[next] Finalizing page optimization ...
Summary by CodeRabbit
Chores
Documentation