Skip to content

feat(helm): add subPath for volumeMount#2834

Merged
M0NsTeRRR merged 2 commits intoseerr-team:developfrom
jisef:develop
Apr 7, 2026
Merged

feat(helm): add subPath for volumeMount#2834
M0NsTeRRR merged 2 commits intoseerr-team:developfrom
jisef:develop

Conversation

@jisef
Copy link
Copy Markdown
Contributor

@jisef jisef commented Apr 7, 2026

Description

Add the option to specify the subPath of a volume which will be mounted into the container.

How Has This Been Tested?

I tested it with no value and seerr. I inspected the PVC to ensure the correct behavior.
Env: kind cluster k8s v1.33.4

If the subPathis not specified the Default "" is taken

Screenshots / Logs (if applicable)

Checklist:

  • I have read and followed the contribution guidelines.
  • Disclosed any use of AI (see our policy)
  • I have updated the documentation accordingly.

Summary by CodeRabbit

  • New Features

    • Added config.persistence.subPath option to allow mounting a specific subpath from a PVC.
  • Documentation

    • Updated chart README to document the new persistence subPath setting and its default.
  • Chores

    • Bumped Helm chart version to 3.4.0.

@jisef jisef requested a review from a team as a code owner April 7, 2026 11:14
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 552d98bb-3080-4d8c-9ddd-6e30b18d35d7

📥 Commits

Reviewing files that changed from the base of the PR and between 70c6913 and 4265885.

📒 Files selected for processing (2)
  • charts/seerr-chart/Chart.yaml
  • charts/seerr-chart/templates/statefulset.yaml
✅ Files skipped from review due to trivial changes (2)
  • charts/seerr-chart/Chart.yaml
  • charts/seerr-chart/templates/statefulset.yaml

📝 Walkthrough

Walkthrough

Adds a configurable config.persistence.subPath value to the Seerr Helm chart, uses it in the StatefulSet volumeMount for /app/config, updates README documentation, and increments the chart version to 3.4.0.

Changes

Cohort / File(s) Summary
Chart metadata
charts/seerr-chart/Chart.yaml
Bumped Helm chart version from 3.3.13.4.0.
Values & defaults
charts/seerr-chart/values.yaml
Added config.persistence.subPath: '' to allow specifying a PVC subpath to mount.
Template
charts/seerr-chart/templates/statefulset.yaml
Set subPath: {{ .Values.config.persistence.subPath }} on the config volumeMount for /app/config.
Documentation
charts/seerr-chart/README.md
Documented new config.persistence.subPath field and added it to the persistence defaults table and description.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested reviewers

  • 0xSysR3ll
  • fallenbagel

Poem

🐰 I nibble code lines, tidy and spry,
A subpath tucked neat where volumes lie,
Configs now whisper the folder to find,
Charts hop ahead, gentle and kind,
Mounting small paths — a rabbit-sized bind.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a subPath configuration option for volumeMount in the Helm chart.
Linked Issues check ✅ Passed The pull request successfully implements the requirement from issue #2628 to enable specifying subPath in volumeMounts within the Helm chart.
Out of Scope Changes check ✅ Passed All changes are within scope: Chart.yaml version bump, values.yaml subPath addition, statefulset.yaml volumeMount modification, and README documentation update.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@M0NsTeRRR M0NsTeRRR changed the title feat: chart: subPath for volumeMount feat(helm): add subPath for volumeMounthttps://github.com/seerr-team/seerr/pull/2834/changes Apr 7, 2026
@M0NsTeRRR M0NsTeRRR changed the title feat(helm): add subPath for volumeMounthttps://github.com/seerr-team/seerr/pull/2834/changes feat(helm): add subPath for volumeMount Apr 7, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
charts/seerr-chart/templates/statefulset.yaml (1)

100-100: Quote subPath to ensure consistent string rendering.

At line 100, subPath renders without quotes. While the current syntax is valid YAML, quoting improves safety by handling special characters and provides explicit string typing:

Proposed fix
-              subPath: {{ or .Values.config.persistence.subPath "" }}
+              subPath: {{ .Values.config.persistence.subPath | default "" | quote }}
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@charts/seerr-chart/templates/statefulset.yaml` at line 100, The subPath value
in templates/statefulset.yaml is rendered unquoted (subPath: {{ or
.Values.config.persistence.subPath "" }}); update this to emit a quoted string
by wrapping the expression with Helm's quote function (e.g., use quote around
the or expression) so that .Values.config.persistence.subPath is always rendered
as a YAML string and special characters are handled safely.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@charts/seerr-chart/templates/statefulset.yaml`:
- Line 100: The subPath value in templates/statefulset.yaml is rendered unquoted
(subPath: {{ or .Values.config.persistence.subPath "" }}); update this to emit a
quoted string by wrapping the expression with Helm's quote function (e.g., use
quote around the or expression) so that .Values.config.persistence.subPath is
always rendered as a YAML string and special characters are handled safely.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b0073a01-3c1d-40f0-8089-bad112035ac3

📥 Commits

Reviewing files that changed from the base of the PR and between 6aeab38 and 70c6913.

📒 Files selected for processing (4)
  • charts/seerr-chart/Chart.yaml
  • charts/seerr-chart/README.md
  • charts/seerr-chart/templates/statefulset.yaml
  • charts/seerr-chart/values.yaml

Copy link
Copy Markdown
Member

@M0NsTeRRR M0NsTeRRR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump minor and not patch as it's an enhancement

Comment thread charts/seerr-chart/templates/statefulset.yaml Outdated
@jisef jisef requested a review from M0NsTeRRR April 7, 2026 15:19
@seerr-automation-bot seerr-automation-bot added this to the v3.2.0 milestone Apr 7, 2026
@M0NsTeRRR M0NsTeRRR merged commit e71f9eb into seerr-team:develop Apr 7, 2026
17 checks passed
lucianchauvin pushed a commit to lucianchauvin/jellyseerr that referenced this pull request Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Helm chart add Subpath in volumeMounts

4 participants