fix(helm): healthcheck endpoint to avoid github rate limit#2837
fix(helm): healthcheck endpoint to avoid github rate limit#2837
Conversation
📝 WalkthroughWalkthroughBumps Helm chart version to 3.4.1 and updates health-check endpoints from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/getting-started/docker.mdx`:
- Line 64: The health-check command currently uses the root URL in the
--health-cmd line ("wget --no-verbose --tries=1 --spider http://localhost:5055
|| exit 1"); update that URL to use the consistent /settings/public endpoint
(http://localhost:5055/settings/public) so it aligns with other docs
(migration-guide, reverse-proxy, and chart templates) and keeps examples
consistent.
In `@docs/migration-guide.mdx`:
- Line 85: The health-check endpoint in docs/migration-guide.mdx uses
/settings/public but docs/getting-started/docker.mdx still references the root
endpoint (/); update the docker.md/x health-check wget/test lines to use
/settings/public instead of / so both docs match the Kubernetes StatefulSet and
HAProxy configuration; search for occurrences of "wget ... /" or health-check
examples in docs/getting-started/docker.mdx and replace them with the exact
"/settings/public" endpoint and ensure any descriptive text or example commands
reflect this change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: de6e336c-6a6d-40d1-9271-0cde3b095126
📒 Files selected for processing (6)
charts/seerr-chart/Chart.yamlcharts/seerr-chart/README.mdcharts/seerr-chart/templates/statefulset.yamldocs/extending-seerr/reverse-proxy.mdxdocs/getting-started/docker.mdxdocs/migration-guide.mdx
9bbb135 to
9aeada5
Compare
Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>
9aeada5 to
052a1f1
Compare
…m#2837) Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>
Description
Improve the health check by using an endpoint that does not depend on external resources.
linked to #2796
How Has This Been Tested?
n/a
Screenshots / Logs (if applicable)
Checklist:
pnpm buildpnpm i18n:extractSummary by CodeRabbit
Chores
Documentation