Skip to content

fix(helm): healthcheck endpoint to avoid github rate limit#2837

Merged
M0NsTeRRR merged 1 commit intodevelopfrom
fix/improve-healthcheck
Apr 8, 2026
Merged

fix(helm): healthcheck endpoint to avoid github rate limit#2837
M0NsTeRRR merged 1 commit intodevelopfrom
fix/improve-healthcheck

Conversation

@M0NsTeRRR
Copy link
Copy Markdown
Member

@M0NsTeRRR M0NsTeRRR commented Apr 7, 2026

Description

Improve the health check by using an endpoint that does not depend on external resources.

linked to #2796

How Has This Been Tested?

n/a

Screenshots / Logs (if applicable)

Checklist:

  • I have read and followed the contribution guidelines.
  • Disclosed any use of AI (see our policy)
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

Summary by CodeRabbit

  • Chores

    • Bumped Helm chart version to 3.4.1
  • Documentation

    • Updated Docker health-check examples (Linux/macOS/Windows) to use the current endpoint
    • Updated reverse-proxy (HAProxy) health-check example to use the current endpoint
    • Updated migration guide with revised health-check examples
    • Refreshed Helm chart README version badge

@M0NsTeRRR M0NsTeRRR requested a review from a team as a code owner April 7, 2026 22:25
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 7, 2026

📝 Walkthrough

Walkthrough

Bumps Helm chart version to 3.4.1 and updates health-check endpoints from /api/v1/status to /api/v1/settings/public across the Helm StatefulSet, Docker and Docker Compose examples, HAProxy example, and README badge.

Changes

Cohort / File(s) Summary
Chart Metadata
charts/seerr-chart/Chart.yaml, charts/seerr-chart/README.md
Incremented Helm chart version to 3.4.1; README badge updated to match.
Kubernetes StatefulSet
charts/seerr-chart/templates/statefulset.yaml
Updated livenessProbe.httpGet.path and readinessProbe.httpGet.path from /api/v1/status/api/v1/settings/public.
Docs — Docker & Migration
docs/getting-started/docker.mdx, docs/migration-guide.mdx
Replaced Docker/Docker Compose healthcheck URLs to use http://localhost:5055/api/v1/settings/public.
Docs — Reverse Proxy
docs/extending-seerr/reverse-proxy.mdx
Updated HAProxy option httpchk from GET /api/v1/statusGET /api/v1/settings/public.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • 0xSysR3ll
  • fallenbagel

Poem

🐇 I nibble lines of YAML and cheer,

I hop from /status to a brighter frontier.
Charts updated, docs all in a scroll,
Healthchecks find home — the service is whole.
🥕

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating healthcheck endpoints from /api/v1/status to /api/v1/settings/public to avoid GitHub rate limiting.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@seerr-team seerr-team deleted a comment from github-actions Bot Apr 7, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/getting-started/docker.mdx`:
- Line 64: The health-check command currently uses the root URL in the
--health-cmd line ("wget --no-verbose --tries=1 --spider http://localhost:5055
|| exit 1"); update that URL to use the consistent /settings/public endpoint
(http://localhost:5055/settings/public) so it aligns with other docs
(migration-guide, reverse-proxy, and chart templates) and keeps examples
consistent.

In `@docs/migration-guide.mdx`:
- Line 85: The health-check endpoint in docs/migration-guide.mdx uses
/settings/public but docs/getting-started/docker.mdx still references the root
endpoint (/); update the docker.md/x health-check wget/test lines to use
/settings/public instead of / so both docs match the Kubernetes StatefulSet and
HAProxy configuration; search for occurrences of "wget ... /" or health-check
examples in docs/getting-started/docker.mdx and replace them with the exact
"/settings/public" endpoint and ensure any descriptive text or example commands
reflect this change.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: de6e336c-6a6d-40d1-9271-0cde3b095126

📥 Commits

Reviewing files that changed from the base of the PR and between e71f9eb and 1b646f2.

📒 Files selected for processing (6)
  • charts/seerr-chart/Chart.yaml
  • charts/seerr-chart/README.md
  • charts/seerr-chart/templates/statefulset.yaml
  • docs/extending-seerr/reverse-proxy.mdx
  • docs/getting-started/docker.mdx
  • docs/migration-guide.mdx

Comment thread docs/getting-started/docker.mdx Outdated
Comment thread docs/migration-guide.mdx Outdated
@M0NsTeRRR M0NsTeRRR force-pushed the fix/improve-healthcheck branch 2 times, most recently from 9bbb135 to 9aeada5 Compare April 7, 2026 22:30
Comment thread charts/seerr-chart/templates/statefulset.yaml Outdated
Comment thread charts/seerr-chart/templates/statefulset.yaml Outdated
Comment thread docs/extending-seerr/reverse-proxy.mdx Outdated
Comment thread docs/migration-guide.mdx Outdated
Comment thread docs/migration-guide.mdx Outdated
Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>
@M0NsTeRRR M0NsTeRRR force-pushed the fix/improve-healthcheck branch from 9aeada5 to 052a1f1 Compare April 7, 2026 22:35
@M0NsTeRRR M0NsTeRRR requested a review from fallenbagel April 7, 2026 22:36
@seerr-automation-bot seerr-automation-bot added this to the v3.2.0 milestone Apr 7, 2026
@fallenbagel fallenbagel changed the title fix: healthcheck endpoint to avoid github rate limit fix(helm): healthcheck endpoint to avoid github rate limit Apr 8, 2026
@M0NsTeRRR M0NsTeRRR merged commit 86acc41 into develop Apr 8, 2026
23 checks passed
@M0NsTeRRR M0NsTeRRR deleted the fix/improve-healthcheck branch April 8, 2026 06:21
lucianchauvin pushed a commit to lucianchauvin/jellyseerr that referenced this pull request Apr 20, 2026
…m#2837)

Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants