feat(helm): add service annotations#2979
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughHelm chart Changes
Sequence Diagram(s)(omitted — changes are minor template/values updates that don't introduce multi-component control flow) Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@charts/seerr-chart/values.yaml`:
- Around line 73-74: The default values.yaml sets an opinionated annotation
under the annotations key (tailscale.com/expose: 'true'); remove that default
and replace it with an empty map/object for annotations so users can opt-in to
integrations and match the README (i.e., leave annotations as {} by default
rather than including tailscale.com/expose).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 462af161-44c0-479f-bba0-1f20e18a3828
📒 Files selected for processing (4)
charts/seerr-chart/Chart.yamlcharts/seerr-chart/README.mdcharts/seerr-chart/templates/service.yamlcharts/seerr-chart/values.yaml
Removed Tailscale annotation from service configuration.
Description
Service annotations are not currently supported by the chart. My main goal is to use Tailscale operator, which requires exposing a service with an annotation
tailscale.com/expose: "true". So this change allows helm chart user to do just that.How Has This Been Tested?
Change has been ran in kind and in k3s cluster.
Checklist:
pnpm buildpnpm i18n:extractSummary by CodeRabbit
New Features
Chores