Skip to content

feat(helm): add service annotations#2979

Merged
M0NsTeRRR merged 3 commits intoseerr-team:developfrom
marcinjurczak:helm-service-annotations
May 1, 2026
Merged

feat(helm): add service annotations#2979
M0NsTeRRR merged 3 commits intoseerr-team:developfrom
marcinjurczak:helm-service-annotations

Conversation

@marcinjurczak
Copy link
Copy Markdown
Contributor

@marcinjurczak marcinjurczak commented Apr 30, 2026

Description

Service annotations are not currently supported by the chart. My main goal is to use Tailscale operator, which requires exposing a service with an annotation tailscale.com/expose: "true". So this change allows helm chart user to do just that.

How Has This Been Tested?

Change has been ran in kind and in k3s cluster.

Checklist:

  • I have read and followed the contribution guidelines.
  • Disclosed any use of AI (see our policy)
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

Summary by CodeRabbit

  • New Features

    • Added optional support for user-defined Service annotations to customize Kubernetes Service metadata.
    • Documentation updated to describe the new annotations option.
  • Chores

    • Bumped Helm chart version to 3.6.0

@marcinjurczak marcinjurczak requested a review from a team as a code owner April 30, 2026 17:27
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f7532e9a-9c47-4730-b950-afbfd4c27aef

📥 Commits

Reviewing files that changed from the base of the PR and between fe9e356 and 1035cf2.

📒 Files selected for processing (2)
  • charts/seerr-chart/Chart.yaml
  • charts/seerr-chart/README.md
✅ Files skipped from review due to trivial changes (2)
  • charts/seerr-chart/README.md
  • charts/seerr-chart/Chart.yaml

📝 Walkthrough

Walkthrough

Helm chart charts/seerr-chart version bumped from 3.5.1 to 3.6.0. Added support for user-provided service.annotations (values and conditional in Service template). README badge updated to reflect new chart version and documents the new service.annotations value.

Changes

Cohort / File(s) Summary
Chart metadata & docs
charts/seerr-chart/Chart.yaml, charts/seerr-chart/README.md
Bumped chart version 3.5.1 → 3.6.0; updated README version badge and documented new service.annotations value.
Service template & values
charts/seerr-chart/templates/service.yaml, charts/seerr-chart/values.yaml
Introduced service.annotations in values.yaml (default {}) and a conditional in templates/service.yaml to render metadata.annotations from that value.

Sequence Diagram(s)

(omitted — changes are minor template/values updates that don't introduce multi-component control flow)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • M0NsTeRRR
  • 0xSysR3ll
  • fallenbagel

Poem

🐰 I nudged a chart with gentle paws,
A tiny annotation now has cause.
Bumped to 3.6.0 with cheer,
Values and README clear,
Helm hops onward—snacks and applause! 🎉

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat(helm): add service annotations' directly and clearly matches the main change in the PR: adding service.annotations support to the Helm chart values, template, and documentation.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@charts/seerr-chart/values.yaml`:
- Around line 73-74: The default values.yaml sets an opinionated annotation
under the annotations key (tailscale.com/expose: 'true'); remove that default
and replace it with an empty map/object for annotations so users can opt-in to
integrations and match the README (i.e., leave annotations as {} by default
rather than including tailscale.com/expose).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 462af161-44c0-479f-bba0-1f20e18a3828

📥 Commits

Reviewing files that changed from the base of the PR and between b32ab02 and e44ae3f.

📒 Files selected for processing (4)
  • charts/seerr-chart/Chart.yaml
  • charts/seerr-chart/README.md
  • charts/seerr-chart/templates/service.yaml
  • charts/seerr-chart/values.yaml

Comment thread charts/seerr-chart/values.yaml Outdated
Removed Tailscale annotation from service configuration.
Comment thread charts/seerr-chart/Chart.yaml Outdated
@M0NsTeRRR M0NsTeRRR enabled auto-merge (squash) April 30, 2026 23:38
@seerr-automation-bot seerr-automation-bot added this to the v3.3.0 milestone Apr 30, 2026
@M0NsTeRRR M0NsTeRRR merged commit 47ca2ba into seerr-team:develop May 1, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants