Skip to content

fix(tag): use inset ring to avoid clipped outlines#2985

Open
0xSysR3ll wants to merge 1 commit intodevelopfrom
0xsysr3ll/fix/tag-ring-clipping
Open

fix(tag): use inset ring to avoid clipped outlines#2985
0xSysR3ll wants to merge 1 commit intodevelopfrom
0xsysr3ll/fix/tag-ring-clipping

Conversation

@0xSysR3ll
Copy link
Copy Markdown
Contributor

@0xSysR3ll 0xSysR3ll commented May 2, 2026

Description

This PR fixes tags being cut off on the last row by keeping the ring inside and slightly adjusting the text spacing.

How Has This Been Tested?

Go to Family Guy series details page and see.

Screenshots / Logs (if applicable)

Before

image

After

image

Checklist:

  • I have read and followed the contribution guidelines.
  • Disclosed any use of AI (see our policy)
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

Summary by CodeRabbit

Release Notes

  • Style
    • Enhanced Tag component styling with refined typography spacing and border refinements for improved visual consistency.

@0xSysR3ll 0xSysR3ll requested a review from a team as a code owner May 2, 2026 17:53
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2847da4b-d98f-412f-93f8-e6367680496b

📥 Commits

Reviewing files that changed from the base of the PR and between 4742018 and e49d742.

📒 Files selected for processing (1)
  • src/components/Common/Tag/index.tsx

📝 Walkthrough

Walkthrough

The Tag component's root element styling is updated to add leading-snug for typography and ring-inset for ring styling. No functional or structural changes are made.

Changes

Tag Component Styling

Layer / File(s) Summary
Styling Update
src/components/Common/Tag/index.tsx
Root <div> class string updated: adds leading-snug to typography classes and changes ring classes to ring-1 ring-inset ring-gray-600.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

bug

Suggested reviewers

  • fallenbagel
  • M0NsTeRRR

Poem

🐰 A little tweak to make tags snug,
With inset rings, they'll fit just right,
No logic bent, just CSS love,
This tiny change brings visual delight! ✨

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: adding inset ring styling to the Tag component to prevent clipped outlines, which aligns with the summary and PR objectives.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@0xSysR3ll 0xSysR3ll enabled auto-merge (squash) May 3, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant