Add type to device context#655
Merged
prayansh merged 1 commit intosegmentio:masterfrom Jun 1, 2020
joinregimen:device-type
Merged
Add type to device context#655prayansh merged 1 commit intosegmentio:masterfrom joinregimen:device-type
prayansh merged 1 commit intosegmentio:masterfrom
joinregimen:device-type
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the type to the device context (Customer.io for example requires the device type to be set [alongside the device token] in order to recognize devices). The Segment iOS SDK is already setting the type.
How should this be manually tested?
Check in Segment’s event debugger if new events contain the
typekey within theircontext/devicedictionary.Any background context you want to provide?
We are developing in React Native and are using Firebase Cloud Messaging (via React Native Firebase). We want to use Customer.io to send out push notifications, so we are working on a pull request for the Segment React Native SDK to add functionality which is required to make this happen. Before we can continue our work we need a way to set the device type in Android – hence this pull request.
What are the relevant tickets?
segmentio/analytics-react-native#38
Questions:
No.
No.
No.