Skip to content

fix(android): register setIDFA function correctly for native bridge #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ondreyz wants to merge 1 commit into from
Closed

fix(android): register setIDFA function correctly for native bridge #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/core/android/src/main/java/com/segment/analytics/reactnative/core/RNAnalytics.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@ object RNAnalytics {
private val integrations = mutableSetOf<Integration.Factory>()
private val onReadyCallbacks = mutableMapOf<String, Analytics.Callback<Any?>>()

fun setIDFA(idfa: String) {
// do nothing; iOS only.
}

fun addIntegration(integration: Integration.Factory) {
integrations.add(integration)
}
Expand Down
5 changes: 5 additions & 0 deletions ...es/core/android/src/main/java/com/segment/analytics/reactnative/core/RNAnalyticsModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,11 @@ class RNAnalyticsModule(context: ReactApplicationContext): ReactContextBaseJavaM
@ReactMethod
fun getAnonymousId(promise: Promise) =
promise.resolve(analytics.getAnalyticsContext().traits().anonymousId())

@ReactMethod
fun setIDFA(idfa: String) {
// do nothing; iOS only.
}
}

private fun optionsFrom(context: ReadableMap?, integrations: ReadableMap?): Options {
Expand Down