Skip to content

add circle jobs to test installation with go get#138

Closed
nickatsegment wants to merge 1 commit intomasterfrom
add-test-for-go-get
Closed

add circle jobs to test installation with go get#138
nickatsegment wants to merge 1 commit intomasterfrom
add-test-for-go-get

Conversation

@nickatsegment
Copy link
Contributor

No description provided.

@eculver
Copy link

eculver commented Sep 21, 2018

LGTM, but it looks like this should depend on #123 otherwise this will generate new go.{mod,sum} every time its run w/ GO111MODULE=on.

Copy link

@eculver eculver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest waiting for and rebasing on #123.

@nickatsegment nickatsegment mentioned this pull request Sep 26, 2018
@nickatsegment
Copy link
Contributor Author

Superseded by #144

@alberts alberts deleted the add-test-for-go-get branch February 14, 2019 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants