Conversation
* repl is set to read-only by default * update README
hhahn-tw
left a comment
hhahn-tw
left a comment
There was a problem hiding this comment.
Hello, and thank you for your pull request. I'm sure many will be happy to be able to delete topics via topicctl and we appreciate your contribution.
After some deliberation, we've come to a consensus that the changes to make the repl mode write-capable do not fit the design goals at this time. It is something to consider in the future but it would make more sense as a part of a larger comprehensive overhaul rather than a singleton use case.
Could you resubmit without the repl changes?
|
|
||
| // DeleteTopic deletes a single topic. | ||
| func (c *CLIRunner) DeleteTopic(ctx context.Context, topic string) error { | ||
| confirm, err := apply.Confirm(fmt.Sprintf("Delete topic \"%s\"", topic), false) |
There was a problem hiding this comment.
This asks for confirmation without verifying it's an existing topic which can be confusing. In the interest of taking every step to confirm safe operation, can you add a check here that a topic of the given name exists prior to asking user confirmation?
cmd/topicctl/subcmd/delete.go
Outdated
| Long: strings.Join( | ||
| []string{ | ||
| "Deletes instances of a particular type.", | ||
| "Supported types currently include: topic.", |
There was a problem hiding this comment.
I don't see any other obvious resource types a delete function would be applicable to - did you have something in mind?
|
Superseding this with #163 due to inactivity |
3 participants
Repl has been set to read only mode to prevent accidental deletes, configurable through CLI flag.
Delete operation must be confirmed with a yes/no