fix: honor sasl params at command line over config file#226
Merged
Conversation
petedannemann
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if spec.sasl.secretsManagerArn is defined in a cluster configuration file, it will take precedence over values for sasl-username and sasl-password provided at the command line.
This is contrary to conventional patterns of precedence where CLI options are highest, followed by env, file, and defaults. Furthermore, in certain contexts (eg tooling automation) it may not be feasible to change the given cluster configuration file, making it impossible to override to a different SASL credential.
This PR corrects this and when overriding configuration ("overriding", according to topicctl, occurs via CLI or env) for sasl-username and sasl-password, it ensures secretsManagerArn is not used (whether from config file or itself an override).