Open
Conversation
Contributor
Author
|
Updated PR title and the initial comment |
Contributor
Author
|
Rebased commits on origin/master |
Contributor
Author
|
Last two commits add:
|
7635b5d to
d44745a
Compare
Contributor
Author
|
Rebased on origin/master |
2a8a45b to
514820b
Compare
Contributor
Author
|
Contributor
Author
|
Contributor
Author
|
- For each detected asset, display its line number and header snippet for reference. - When asset data cannot be found or the number of values detected is incorrect, and inline error message is displayed instead of a (broken) asset editor.
align-items: flex-start
Use bpw or verilog spec to pad correct number of chars.
Do not treat a new asset block as the end of a previous block
Asset editor replaces text ranges instead of the entire source file. Undo inside the source code now scrolls asset editor edits into view, and selects the text being edited, so that what is being (un)edited is much clearer. Also, undo history is no longer burdened by full file edits.
Add calculation of maximum reachable offset. Fixes errors with `chr_generic.s`
Fix broken asset edit and undo when the asset source file has not been opened manually, for example when reloading the #asseteditor page directly.
- Track selected asset in hash - Highlight selected asset on navigation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.