Merged
Conversation
philipsu522
approved these changes
Jul 12, 2022
philipsu522
approved these changes
Jul 12, 2022
alg747
pushed a commit
to UXDProtocol/sei-chain
that referenced
this pull request
Jul 20, 2022
* golangci-lint in ci * linting per .golangci.yml
masih
pushed a commit
that referenced
this pull request
Sep 29, 2025
## Describe your changes and provide context Since external packages like wasmd and ibc depends on cosmos's store interface, we cannot introduce interface-breaking changes. This makes passing custom cache limit impossible, so here we change it to be a default value for now (1 million). We would likely need to fork wasmd and ibc if we want the ability to specify custom cache limit, or introduce any change that breaks interface in general. ## Testing performed to validate your change built with sei-chain
masih
pushed a commit
that referenced
this pull request
Sep 30, 2025
## Describe your changes and provide context Since external packages like wasmd and ibc depends on cosmos's store interface, we cannot introduce interface-breaking changes. This makes passing custom cache limit impossible, so here we change it to be a default value for now (1 million). We would likely need to fork wasmd and ibc if we want the ability to specify custom cache limit, or introduce any change that breaks interface in general. ## Testing performed to validate your change built with sei-chain
masih
pushed a commit
that referenced
this pull request
Oct 9, 2025
#118) This reverts commit c35c30a, reversing changes made to 302e86d. ## Describe your changes and provide context - Revert surfacing errors from db layer since the rpc / keeper / store layer hard codes a lot of handling of record not found and there needs to be a larger refactor - Can re introduce this error after a redesign and consideration of impact ## Testing performed to validate your change - Verified in unit tests and on node
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives Sei the same golang-ci lint settings that I used for ibc-go.
cosmos/ibc-go#1418
They are pretty strict and this may initially fail.