[EVM] call SendCoinsAndWei to support 18-decimal point precision#1191
Merged
[EVM] call SendCoinsAndWei to support 18-decimal point precision#1191
Conversation
9e4778a to
a65af36
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## evm #1191 +/- ##
==========================================
- Coverage 66.17% 66.06% -0.12%
==========================================
Files 329 329
Lines 21536 21552 +16
==========================================
- Hits 14252 14238 -14
- Misses 6509 6540 +31
+ Partials 775 774 -1
|
codchen
added a commit
that referenced
this pull request
Jan 5, 2024
* [EVM] call SendCoinsAndWei to support 18-decimal point precision * add ACL type for wei balance
codchen
added a commit
that referenced
this pull request
Jan 8, 2024
* [EVM] call SendCoinsAndWei to support 18-decimal point precision * add ACL type for wei balance
udpatil
pushed a commit
that referenced
this pull request
Jan 31, 2024
* [EVM] call SendCoinsAndWei to support 18-decimal point precision * add ACL type for wei balance
udpatil
pushed a commit
that referenced
this pull request
Feb 28, 2024
* [EVM] call SendCoinsAndWei to support 18-decimal point precision * add ACL type for wei balance
udpatil
pushed a commit
that referenced
this pull request
Feb 28, 2024
* [EVM] call SendCoinsAndWei to support 18-decimal point precision * add ACL type for wei balance
udpatil
pushed a commit
that referenced
this pull request
Feb 28, 2024
* [EVM] call SendCoinsAndWei to support 18-decimal point precision * add ACL type for wei balance
udpatil
pushed a commit
that referenced
this pull request
Mar 4, 2024
* [EVM] call SendCoinsAndWei to support 18-decimal point precision * add ACL type for wei balance
udpatil
pushed a commit
that referenced
this pull request
Mar 4, 2024
* [EVM] call SendCoinsAndWei to support 18-decimal point precision * add ACL type for wei balance
udpatil
pushed a commit
that referenced
this pull request
Mar 11, 2024
* [EVM] call SendCoinsAndWei to support 18-decimal point precision * add ACL type for wei balance
udpatil
pushed a commit
that referenced
this pull request
Mar 26, 2024
* [EVM] call SendCoinsAndWei to support 18-decimal point precision * add ACL type for wei balance
udpatil
pushed a commit
that referenced
this pull request
Apr 17, 2024
* [EVM] call SendCoinsAndWei to support 18-decimal point precision * add ACL type for wei balance
udpatil
pushed a commit
that referenced
this pull request
Apr 17, 2024
* [EVM] call SendCoinsAndWei to support 18-decimal point precision * add ACL type for wei balance
udpatil
pushed a commit
that referenced
this pull request
Apr 17, 2024
* [EVM] call SendCoinsAndWei to support 18-decimal point precision * add ACL type for wei balance
udpatil
pushed a commit
that referenced
this pull request
Apr 18, 2024
* [EVM] call SendCoinsAndWei to support 18-decimal point precision * add ACL type for wei balance
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
* [EVM] call SendCoinsAndWei to support 18-decimal point precision * add ACL type for wei balance
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
* [EVM] call SendCoinsAndWei to support 18-decimal point precision * add ACL type for wei balance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Previously we were truncating any amount after the sixth decimal point in balance operations, which could cause confusion to some developers or just outright render some applications unusable. This PR makes use of the new bank keeper functions introduced in sei-protocol/sei-cosmos#386 to handle amounts up to 18 decimal points properly.
Testing performed to validate your change
unit test
integrated with local sei