Add more CW20 methods to ERC20 Wrapper by mj850 · Pull Request #1255 · sei-protocol/sei-chain

mj850 · 2024-01-18T19:09:00Z

Describe your changes and provide context

We want to expand the ERC20 wrapper contract to include other endpoints from the original ERC20 contract.

So far we've added
Execute:

Transfer
TransferFrom
Burn (Noop)
Mint (Noop)
Send
SendFrom
IncreaseAllowance
DecreaseAllowance.

Query:

Allowance

Still missing:

BurnFrom (NoOp)
Other query methods

Testing performed to validate your change

Only unit tests

* Initial commit for producer/consumer loadtest client * update sei-cosmos * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * rm rounds * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * finalize * debug * debug * debug * debug * debug * debug * debug * debug * bump cosmos * gofmt * debug * debug

* Bump version to v3.6.0 * Fix empty branch * Bump cosmos to fix upgrade migration * Update version * Fix changelogs readme * Bump tendermint version * Fix version * Add 3.6.1 upgrade handler * Supress lint

* Add seidb migration steps * Add migration process for SeiDB * Fix * Update seidb_migration.md

* debug * debug * debug * set default broadcast to sync * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * grpc * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * lint * int

* Fix account loading in loadtest client * Fix account loading in loadtest client * debug * debug * debug * debug * debug * debug * debug * debug * update

codecov · 2024-01-23T21:30:30Z

Codecov Report

Attention: 61 lines in your changes are missing coverage. Please review.

Comparison is base (a1f89a6) 63.99% compared to head (06d66e8) 63.65%.

Additional details and impacted files

@@            Coverage Diff             @@
##              evm    #1255      +/-   ##
==========================================
- Coverage   63.99%   63.65%   -0.35%     
==========================================
  Files         346      346              
  Lines       23073    23162      +89     
==========================================
- Hits        14766    14743      -23     
- Misses       7471     7579     +108     
- Partials      836      840       +4

Files	Coverage Δ
x/evm/client/wasm/query.go	`35.89% <31.46%> (+4.86%)`	⬆️

... and 4 files with indirect coverage changes

* Initial commit for producer/consumer loadtest client (#1190) * Initial commit for producer/consumer loadtest client * update sei-cosmos * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * rm rounds * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * finalize * debug * debug * debug * debug * debug * debug * debug * debug * bump cosmos * gofmt * debug * debug * Bump version to v3.6.1 (#1222) * Bump version to v3.6.0 * Fix empty branch * Bump cosmos to fix upgrade migration * Update version * Fix changelogs readme * Bump tendermint version * Fix version * Add 3.6.1 upgrade handler * Supress lint * Add migration process readme for SeiDB (#1221) * Add seidb migration steps * Add migration process for SeiDB * Fix * Update seidb_migration.md * Loadtest producer consumer various fixes (#1227) * debug * debug * debug * set default broadcast to sync * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * grpc * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * debug * lint * int * Add TransferFrom method to contract and bindings * Lt client fix (#1260) * Fix account loading in loadtest client * Fix account loading in loadtest client * debug * debug * debug * debug * debug * debug * debug * debug * update * base * base with error * comments * fix bug * old additions * revert merge * pre merge * issues * add tests for transfer and transferFrom * add approve functions * add send_from --------- Co-authored-by: Philip Su <philip.su.522@gmail.com> Co-authored-by: Yiming Zang <50607998+yzang2019@users.noreply.github.com> Co-authored-by: Mingjun <mj@mingjuns-mbp.lan>

## Description I noticed that 2 links at the bottom of the applications docs page were not correct. closes: #XXXX --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [x] Re-reviewed `Files changed` in the Github PR explorer - [ ] Review `Codecov Report` in the comment section below once CI passes (cherry picked from commit 31d577648124e4b9242b202f6c4521231cbb7b7c) Co-authored-by: Carlos Rodriguez <carlos@interchain.io>

philipsu522 and others added 8 commits January 9, 2024 14:21

Bump version to v3.6.1 (#1222)

593ed18

* Bump version to v3.6.0 * Fix empty branch * Bump cosmos to fix upgrade migration * Update version * Fix changelogs readme * Bump tendermint version * Fix version * Add 3.6.1 upgrade handler * Supress lint

Add migration process readme for SeiDB (#1221)

23542c3

* Add seidb migration steps * Add migration process for SeiDB * Fix * Update seidb_migration.md

Add TransferFrom method to contract and bindings

a51e7fb

Lt client fix (#1260)

167d699

* Fix account loading in loadtest client * Fix account loading in loadtest client * debug * debug * debug * debug * debug * debug * debug * debug * update

base

bdae9e7

base with error

5d937f9

mj850 changed the title ~~Add TransferFrom method to contract and bindings~~ Add more CW20 methods to ERC20 Wrapper Jan 22, 2024

mj850 added 8 commits January 22, 2024 18:44

comments

beeb2c1

fix bug

18b4e4a

merge

3c8fd57

old additions

235d4d4

revert merge

c0fba62

pre merge

76bc301

merge evm

4d634d2

issues

a5d7150

mj850 added 2 commits January 23, 2024 16:48

add tests for transfer and transferFrom

34acf27

add approve functions

a0f4e45

mj850 requested a review from codchen January 23, 2024 23:34

add send_from

cd13aa3

codchen approved these changes Jan 24, 2024

View reviewed changes

Merge branch 'evm' into mj/cw20erc20ext

06d66e8

mj850 merged commit 8c8776b into evm Jan 24, 2024

mj850 deleted the mj/cw20erc20ext branch January 24, 2024 14:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add more CW20 methods to ERC20 Wrapper#1255

Add more CW20 methods to ERC20 Wrapper#1255
mj850 merged 20 commits intoevmfrom
mj/cw20erc20ext

mj850 commented Jan 18, 2024 •

edited

Loading

Uh oh!

codecov bot commented Jan 23, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

mj850 commented Jan 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes and provide context

Testing performed to validate your change

Uh oh!

codecov bot commented Jan 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mj850 commented Jan 18, 2024 •

edited

Loading

codecov bot commented Jan 23, 2024 •

edited

Loading