Merged
Conversation
codchen
approved these changes
Jul 18, 2022
philipsu522
added a commit
that referenced
this pull request
Jul 19, 2022
* Rm unneeded files * run gofumpt * Ignore err check
alg747
pushed a commit
to UXDProtocol/sei-chain
that referenced
this pull request
Jul 20, 2022
* Rm unneeded files * run gofumpt * Ignore err check
masih
pushed a commit
that referenced
this pull request
Sep 29, 2025
…129) ## Describe your changes and provide context This adds the conservative fallback behavior for the JQ selectors when processing a contract reference. Because we are in a contract reference, we don't necessarily know that the JSON body is proper, therefore if a JQ selector doesn't have a match, we have to conservatively assume that it is because the JSON incorrectly doesn't include that field instead of the dependency not being necessary. As a result, these JQ selectors will modify the identifier template to be "*" (aka the conservative value for that resource) in the case that the selector doesn't have a match ## Testing performed to validate your change Updated unit tests to verify this behavior and also to test that we properly discard JQ selectors when NOT in a contract reference.
masih
pushed a commit
that referenced
this pull request
Sep 30, 2025
…129) ## Describe your changes and provide context This adds the conservative fallback behavior for the JQ selectors when processing a contract reference. Because we are in a contract reference, we don't necessarily know that the JSON body is proper, therefore if a JQ selector doesn't have a match, we have to conservatively assume that it is because the JSON incorrectly doesn't include that field instead of the dependency not being necessary. As a result, these JQ selectors will modify the identifier template to be "*" (aka the conservative value for that resource) in the case that the selector doesn't have a match ## Testing performed to validate your change Updated unit tests to verify this behavior and also to test that we properly discard JQ selectors when NOT in a contract reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#113 actually created lint errors. Remove these tests (osmosis doesn't have it either: https://sourcegraph.com/github.com/osmosis-labs/osmosis@2d0ef14/-/tree/x/mint/client)