Integrate with tendermint EVM tx replacement logic#1394
Closed
Conversation
a4262ab to
4ab8c40
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## evm #1394 +/- ##
==========================================
+ Coverage 63.02% 63.32% +0.30%
==========================================
Files 350 350
Lines 23760 23788 +28
==========================================
+ Hits 14974 15064 +90
+ Misses 7926 7861 -65
- Partials 860 863 +3
🚀 New features to boost your workflow:
|
philipsu522
reviewed
Mar 1, 2024
| if err != nil { | ||
| return err | ||
| var nonce uint64 | ||
| if n, err := cmd.Flags().GetInt64(FlagNonce); err == nil && n >= 0 { |
Contributor
There was a problem hiding this comment.
let's add --nonce to the command usage string?
| if pendingTx.Nonce == nonce { | ||
| if priority > pendingTx.Priority { | ||
| // replace existing tx | ||
| delete(k.keyToNonce, pendingTx.Key) |
Contributor
There was a problem hiding this comment.
do we also need to update tendermint's pending tx list somewhere here? i don't think so but wanted to double check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
See description in sei-protocol/sei-tendermint#206
This PR also includes changes to handle duplicate nonces in the pending nonce list in
evmKeeperTesting performed to validate your change
local sei test