Skip to content

Set gas limit in parameter for Begin/EndBlock in dex#21

Merged
codchen merged 1 commit intomasterfrom
tony-chen-gas-limit
Nov 24, 2022
Merged

Set gas limit in parameter for Begin/EndBlock in dex#21
codchen merged 1 commit intomasterfrom
tony-chen-gas-limit

Conversation

@codchen
Copy link
Collaborator

@codchen codchen commented May 29, 2022

Set a gas limit for both Begin/EndBlock. If the gas limit is hit, all store writes need to be aborted, which is achieved via the usage of cache store.

@codchen codchen force-pushed the tony-chen-gas-limit branch from 3d22cc1 to c85fe3b Compare November 22, 2022 16:22
@codchen codchen changed the title Override max gas per block Set gas limit in parameter for Begin/EndBlock in dex Nov 22, 2022
@codchen codchen requested a review from LCyson November 22, 2022 16:24
KeyPriceSnapshotRetention = []byte("PriceSnapshotRetention") // number of epochs to retain price snapshots for
KeySudoCallGasPrice = []byte("KeySudoCallGasPrice") // gas price for sudo calls from endblock
KeyBeginBlockGasLimit = []byte("KeyBeginBlockGasLimit")
KeyEndBlockGasLimit = []byte("KeyEndBlockGasLimit")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we using this in the endblock rn?

@codchen codchen force-pushed the tony-chen-gas-limit branch from c85fe3b to cabea9f Compare November 24, 2022 04:52
@codchen codchen merged commit cd2f024 into master Nov 24, 2022
masih pushed a commit that referenced this pull request Sep 26, 2025
Use HexBytes without custom Marshal/UnmarshalJSON functions
masih pushed a commit that referenced this pull request Sep 29, 2025
masih pushed a commit that referenced this pull request Oct 1, 2025
masih pushed a commit that referenced this pull request Oct 9, 2025
Feat: Add QueryMultiStore and Snapshot Manager for StateStore
@masih masih deleted the tony-chen-gas-limit branch October 31, 2025 15:53
masih pushed a commit that referenced this pull request Dec 17, 2025
Remove iterator lock and lock on Node level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants