Merged
Conversation
codchen
force-pushed
the
tony-chen-optimistic-processing
branch
from
2a063a1 to
aaaa8be
Compare
LCyson
approved these changes
Aug 26, 2022
philipsu522
reviewed
Aug 26, 2022
| } | ||
|
|
||
| func (app *App) FinalizeBlocker(ctx sdk.Context, req *abci.RequestFinalizeBlock) (*abci.ResponseFinalizeBlock, error) { | ||
| startTime := time.Now() |
Contributor
There was a problem hiding this comment.
i might need a bit more context, but when is this called? Is this called in a separate thread?
Collaborator
Author
There was a problem hiding this comment.
Both ProcessProposal and FinalizeBlock are called synchronously by tendermint. ProcessProposal spawns an async goroutine which FinalizeBlock may wait on
masih
pushed a commit
that referenced
this pull request
Sep 29, 2025
## Describe your changes and provide context Complaints from validators that the tracing log is really noisy ## Testing performed to validate your change No tracing by default  tracing error if enabeld 
masih
pushed a commit
that referenced
this pull request
Sep 30, 2025
## Describe your changes and provide context Complaints from validators that the tracing log is really noisy ## Testing performed to validate your change No tracing by default  tracing error if enabeld 
masih
pushed a commit
that referenced
this pull request
Oct 1, 2025
* Add metrics for block processing latency * Update execution.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of RFC-000