Conversation
codchen
force-pushed
the
tony-chen-fix-types
branch
from
075039c to
e76ec0c
Compare
philipsu522
reviewed
Jun 1, 2022
| var val legacytypes.LongBook | ||
| cdc.MustUnmarshal(iterator.Value(), &val) | ||
| key := iterator.Key() | ||
| store.Delete(key) |
Contributor
There was a problem hiding this comment.
should we wait until the end to delete?
| key := iterator.Key() | ||
| store.Delete(key) | ||
| priceDenom, err := types.GetDenomFromStr(val.Entry.PriceDenom) | ||
| if err != nil { |
Contributor
There was a problem hiding this comment.
rather than just continuing, should we log it so that we can revisit and try to fix this later? If we delete at the end the value is still there
Collaborator
Author
There was a problem hiding this comment.
together with the .Delete comment above, my thought was to prevent any bad state from lingering in the blockchain after the migration since a bad state could potentially crash the chain during logics in Begin/EndBlock, and I don't know of a good way to fix bad states after migrations. Maybe we can just panic here? So that migration will fail, and we can go back and add in any missed edge cases and rerun migration
codchen
force-pushed
the
tony-chen-fix-types
branch
from
250b27e to
3bc155f
Compare
philipsu522
approved these changes
Jun 5, 2022
masih
pushed a commit
that referenced
this pull request
Sep 29, 2025
* Add accesscontrol module * mod tidy * proto files * move out of param * linting * AccessOps instead * Address comments
masih
pushed a commit
that referenced
this pull request
Sep 30, 2025
* Add accesscontrol module * mod tidy * proto files * move out of param * linting * AccessOps instead * Address comments
masih
pushed a commit
that referenced
this pull request
Oct 1, 2025
* Cherry-pick rollback * debug * change log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
price/quantity/leveragedata type tosdk.Decwhich is a fixed 18-decimal-place numeric representation.nonceTested in local chain with the following steps:
dex(at this point the states are in old data type)