Conversation
udpatil
force-pushed
the
remove-prevote
branch
from
6be01f1 to
698e751
Compare
LCyson
approved these changes
Sep 14, 2022
| ExchangeRates: []ExchangeRateTuple{}, | ||
| FeederDelegations: []FeederDelegation{}, | ||
| PenaltyCounters: []PenaltyCounter{}, | ||
| AggregateExchangeRatePrevotes: []AggregateExchangeRatePrevote{}, |
Contributor
There was a problem hiding this comment.
do we need to remove this from the state in the upgrade handler?
Collaborator
Author
There was a problem hiding this comment.
yes good point, I'll make that change
LCyson
approved these changes
Sep 15, 2022
| store := ctx.KVStore(m.keeper.storeKey) | ||
|
|
||
| oldPrevoteKey := []byte{0x04} | ||
| iter := sdk.KVStorePrefixIterator(store, oldPrevoteKey) |
Contributor
There was a problem hiding this comment.
this removes every in the oracle store right
Collaborator
Author
There was a problem hiding this comment.
yeah it iterates over the store and deletes anything thats prefixed by the prevote key
udpatil
added a commit
that referenced
this pull request
Oct 21, 2022
* [oracle] Remove oracle prevote * lint * remove prevote from store
udpatil
added a commit
that referenced
this pull request
Oct 25, 2022
* [oracle] Remove oracle prevote * lint * remove prevote from store
udpatil
added a commit
that referenced
this pull request
Oct 26, 2022
* [oracle] Remove oracle prevote (#249) * [oracle] Remove oracle prevote * lint * remove prevote from store * [acl] Add oracle parallelization dependencies * [loadtest] Add oracle voting to loadtest * go mod tidy * modified key import * adjust loadtest * remove none msg type * update config * add non message type * add validation unit tests for oracle mapping * refactor loadtest and use new sei-cosmos tag * fix loadtest config * add loadtest to makefile * fix * fix tabs * lint * go mod tidy * refactor loadtest to separate function * fix * fix refactor
udpatil
added a commit
that referenced
this pull request
Oct 28, 2022
* [oracle] Remove oracle prevote (#249) * [oracle] Remove oracle prevote * lint * remove prevote from store * [acl] Add oracle parallelization dependencies * [loadtest] Add oracle voting to loadtest * go mod tidy * modified key import * adjust loadtest * remove none msg type * update config * add non message type * add validation unit tests for oracle mapping * refactor loadtest and use new sei-cosmos tag * fix loadtest config * add loadtest to makefile * fix * fix tabs * lint * go mod tidy * refactor loadtest to separate function * fix * fix refactor
udpatil
added a commit
that referenced
this pull request
Oct 28, 2022
* [oracle] Remove oracle prevote (#249) * [oracle] Remove oracle prevote * lint * remove prevote from store * [acl] Add oracle parallelization dependencies * [loadtest] Add oracle voting to loadtest * go mod tidy * modified key import * adjust loadtest * remove none msg type * update config * add non message type * add validation unit tests for oracle mapping * refactor loadtest and use new sei-cosmos tag * fix loadtest config * add loadtest to makefile * fix * fix tabs * lint * go mod tidy * refactor loadtest to separate function * fix * fix refactor
udpatil
added a commit
that referenced
this pull request
Nov 1, 2022
* [oracle] Remove oracle prevote (#249) * [oracle] Remove oracle prevote * lint * remove prevote from store * [acl] Add oracle parallelization dependencies * [loadtest] Add oracle voting to loadtest * go mod tidy * modified key import * adjust loadtest * remove none msg type * update config * add non message type * add validation unit tests for oracle mapping * refactor loadtest and use new sei-cosmos tag * fix loadtest config * add loadtest to makefile * fix * fix tabs * lint * go mod tidy * refactor loadtest to separate function * fix * fix refactor
udpatil
added a commit
that referenced
this pull request
Nov 1, 2022
* [oracle] Remove oracle prevote (#249) * [oracle] Remove oracle prevote * lint * remove prevote from store * [acl] Add oracle parallelization dependencies * [loadtest] Add oracle voting to loadtest * go mod tidy * modified key import * adjust loadtest * remove none msg type * update config * add non message type * add validation unit tests for oracle mapping * refactor loadtest and use new sei-cosmos tag * fix loadtest config * add loadtest to makefile * fix * fix tabs * lint * go mod tidy * refactor loadtest to separate function * fix * fix refactor
masih
pushed a commit
that referenced
this pull request
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still testing with localsei but here's the PR that removes the prevote functionality