Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2574 +/- ##
==========================================
+ Coverage 43.20% 43.21% +0.01%
==========================================
Files 1450 1856 +406
Lines 115396 152683 +37287
==========================================
+ Hits 49858 65984 +16126
- Misses 61215 80819 +19604
- Partials 4323 5880 +1557
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| sigs := make([]signing.SignatureV2, len(priv)) | ||
|
|
||
| // create a random length memo | ||
| r := rand.New(rand.NewSource(time.Now().UnixNano())) |
Check warning
Code scanning / CodeQL
Calling the system time Warning
| func RandomizedGenState(simState *module.SimulationState) { | ||
| mintDenom := sdk.DefaultBondDenom | ||
| randomProvision := uint64(rand.Int63n(1000000)) //nolint:gosec | ||
| currentDate := time.Now() |
Check warning
Code scanning / CodeQL
Calling the system time Warning
codchen
force-pushed
the
tony/revert-sim-removal
branch
2 times, most recently
from
80efc53 to
72f1f10
Compare
udpatil
approved these changes
Dec 8, 2025
philipsu522
approved these changes
Dec 8, 2025
codchen
force-pushed
the
tony/revert-sim-removal
branch
from
72f1f10 to
7e14726
Compare
codchen
added a commit
that referenced
this pull request
Dec 11, 2025
## Describe your changes and provide context Cosmos simulation logics were removed in an earlier commit https://github.com/sei-protocol/sei-chain/pull/2507/files#diff-0f1d2976054440336a576d47a44a37b80cdf6701dd9113012bce0e3c425819b7 However these logics are still needed by Cosmos-based wallets, so we cannot remove them just yet. ## Testing performed to validate your change add back old logics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Cosmos simulation logics were removed in an earlier commit https://github.com/sei-protocol/sei-chain/pull/2507/files#diff-0f1d2976054440336a576d47a44a37b80cdf6701dd9113012bce0e3c425819b7
However these logics are still needed by Cosmos-based wallets, so we cannot remove them just yet.
Testing performed to validate your change
add back old logics