Skip to content

removed support for secp256k1 and sr25519 as validator keys#2585

Merged
pompon0 merged 16 commits intomainfrom
gprusak-keys
Dec 9, 2025
Merged

removed support for secp256k1 and sr25519 as validator keys#2585
pompon0 merged 16 commits intomainfrom
gprusak-keys

Conversation

@pompon0
Copy link
Copy Markdown
Contributor

@pompon0 pompon0 commented Dec 8, 2025

Only ed25519 will be supported (it is the only enabled validator key scheme on atlantic-2,arctic-1 and pacific-1). This will simplify migration to autobahn.

From now on crypto.PubKey is an alias of ed25519.PubKey. The pr is almost entirely generated with codex.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 8, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedDec 9, 2025, 4:13 PM

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 31.39535% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.26%. Comparing base (6996379) to head (ab25bc3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sei-tendermint/crypto/ed25519/ed25519.go 30.76% 9 Missing ⚠️
loadtest/sign.go 0.00% 5 Missing ⚠️
sei-tendermint/crypto/encoding/codec.go 0.00% 5 Missing ⚠️
sei-cosmos/crypto/keys/sr25519/internal/privkey.go 20.00% 4 Missing ⚠️
sei-tendermint/test/e2e/pkg/testnet.go 0.00% 4 Missing ⚠️
sei-cosmos/crypto/keyring/keyring.go 50.00% 2 Missing and 1 partial ⚠️
sei-cosmos/crypto/keys/sr25519/privkey.go 40.00% 3 Missing ⚠️
sei-tendermint/cmd/tendermint/commands/reset.go 0.00% 3 Missing ⚠️
sei-tendermint/privval/secret_connection.go 70.00% 2 Missing and 1 partial ⚠️
sei-cosmos/crypto/keys/sr25519/internal/pubkey.go 0.00% 2 Missing ⚠️
... and 13 more

❌ Your patch status has failed because the patch coverage (31.39%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (38.28%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2585      +/-   ##
==========================================
+ Coverage   42.00%   43.26%   +1.25%     
==========================================
  Files        1510     1850     +340     
  Lines      118783   152293   +33510     
==========================================
+ Hits        49897    65892   +15995     
- Misses      64558    80538   +15980     
- Partials     4328     5863    +1535     
Flag Coverage Δ
sei-chain 42.10% <11.11%> (+0.02%) ⬆️
sei-cosmos 38.04% <28.57%> (+0.08%) ⬆️
sei-db 69.06% <ø> (-0.22%) ⬇️
sei-ibc-go 55.96% <0.00%> (ø)
sei-tendermint 47.54% <36.36%> (?)
sei-wasmd 42.10% <0.00%> (-0.02%) ⬇️
sei-wasmvm 39.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/app.go 76.54% <ø> (+0.02%) ⬆️
app/test_helpers.go 31.42% <100.00%> (ø)
sei-cosmos/crypto/hd/hdpath.go 98.61% <ø> (-0.04%) ⬇️
sei-tendermint/test/e2e/app/app.go 0.00% <ø> (ø)
sei-tendermint/test/e2e/generator/generate.go 82.31% <ø> (ø)
sei-tendermint/test/e2e/pkg/manifest.go 0.00% <ø> (ø)
x/oracle/keeper/testutils/test_utils.go 0.00% <ø> (ø)
x/oracle/types/test_utils.go 45.71% <ø> (ø)
sei-cosmos/crypto/codec/tm.go 0.00% <0.00%> (ø)
sei-cosmos/crypto/hd/algo.go 0.00% <0.00%> (ø)
... and 21 more

... and 329 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pompon0 pompon0 enabled auto-merge (squash) December 9, 2025 15:34
@pompon0 pompon0 merged commit cf02339 into main Dec 9, 2025
61 of 67 checks passed
@pompon0 pompon0 deleted the gprusak-keys branch December 9, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants