Remove redundant mint protos left behind from Cosmos simulation logic#2586
Merged
Remove redundant mint protos left behind from Cosmos simulation logic#2586
Conversation
We removed sample app and some simulation logic from cosmos as part of: * #2507 ...but forgot to remove the corresponding .proto files. As a resunt, running `go generate ./...` in root results in unexpected go file generation. A separate work will investigate as to why UCI did not pick this issue up at the time.
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
pompon0
approved these changes
Dec 8, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2586 +/- ##
==========================================
- Coverage 44.16% 44.14% -0.02%
==========================================
Files 1796 1796
Lines 149301 149301
==========================================
- Hits 65932 65906 -26
- Misses 77492 77513 +21
- Partials 5877 5882 +5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
sei-will
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We removed sample app and some simulation logic from cosmos as part of:
...but forgot to remove the corresponding .proto files. As a result, running
go generate ./...in root results in unexpected go file generation.A separate work will investigate as to why UCI did not pick this issue up at the time.