Skip to content

Flatten sei-db module#2587

Merged
masih merged 5 commits intomainfrom
masih/sei-db-be-flat-like-a-pancake
Dec 9, 2025
Merged

Flatten sei-db module#2587
masih merged 5 commits intomainfrom
masih/sei-db-be-flat-like-a-pancake

Conversation

@masih
Copy link
Copy Markdown
Collaborator

@masih masih commented Dec 9, 2025

Remove sei-db as a nested go module and instead flatten it into sei-chain top level module.

This simplifies the go module structure and removes one degree of complexity from workspace management.

Remove `sei-db` as a nested go module and instead flatten it into
`sei-chain` top level module.

This simplifies the go module structure and removes one degree of
complexity from workspace management.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 9, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedDec 9, 2025, 2:42 PM

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.20%. Comparing base (c72eccf) to head (6c94af8).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
sei-db/ss/pebbledb/db.go 0.00% 9 Missing ⚠️
x/evm/client/cli/common.go 0.00% 7 Missing ⚠️
sei-db/sc/memiavl/snapshot.go 37.50% 5 Missing ⚠️
sei-db/ss/test/storage_test_suite.go 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2587      +/-   ##
==========================================
+ Coverage   42.00%   43.20%   +1.20%     
==========================================
  Files        1510     1856     +346     
  Lines      118778   152688   +33910     
==========================================
+ Hits        49891    65970   +16079     
- Misses      64558    80834   +16276     
- Partials     4329     5884    +1555     
Flag Coverage Δ
sei-chain 42.08% <33.33%> (+0.18%) ⬆️
sei-cosmos 37.95% <ø> (+<0.01%) ⬆️
sei-db 69.06% <ø> (+24.08%) ⬆️
sei-ibc-go 55.96% <ø> (ø)
sei-tendermint 47.39% <ø> (?)
sei-wasmd 42.11% <ø> (+0.01%) ⬆️
sei-wasmvm 39.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/app.go 76.51% <ø> (ø)
app/params/proto.go 0.00% <ø> (ø)
app/seidb.go 82.69% <ø> (ø)
app/test_helpers.go 31.42% <ø> (ø)
cmd/seid/cmd/app_config.go 100.00% <ø> (ø)
cmd/seid/cmd/root.go 0.00% <ø> (ø)
evmrpc/server.go 91.19% <ø> (ø)
evmrpc/watermark_manager.go 74.46% <ø> (ø)
sei-cosmos/server/config/config.go 94.56% <ø> (ø)
sei-cosmos/storev2/commitment/store.go 9.37% <ø> (ø)
... and 52 more

... and 348 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih masih marked this pull request as ready for review December 9, 2025 15:09
github.com/gonum/lapack v0.0.0-20181123203213-e4cdc5a0bff9 h1:7qnwS9+oeSiOIsiUMajT+0R7HR6hw5NegnKPmn/94oI=
github.com/gonum/matrix v0.0.0-20181209220409-c518dec07be9 h1:V2IgdyerlBa/MxaEFRbV5juy/C3MGdj4ePi+g6ePIp4=
github.com/google/btree v1.1.3/go.mod h1:qOPhT0dTNdNzV6Z/lhRX0YXUafgPLFUh+gZMl761Gm4=
github.com/google/btree v1.0.1/go.mod h1:xXMiIv4Fb/0kKde4SpL7qlzvu5cMJDRkFDxJfI9uaxA=
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi, btree gets reverted to an older version

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this also caught my eye thanks for pointing that out.

This is a transitive dependency. Taking a closer look to see why this happened.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a closer look, this is in go wor sum, and a result of running go work sync. The indirect dependency in sei-chain remains 1.1.3 which is the one ends up being used in the built binary.

@masih masih merged commit 6996379 into main Dec 9, 2025
42 of 44 checks passed
@masih masih deleted the masih/sei-db-be-flat-like-a-pancake branch December 9, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants