refactor: mempool: remove unused totalCheckTxCount#2589
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (38.27%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2589 +/- ##
==========================================
+ Coverage 42.04% 43.24% +1.20%
==========================================
Files 1512 1851 +339
Lines 119181 152771 +33590
==========================================
+ Hits 50107 66073 +15966
- Misses 64729 80825 +16096
- Partials 4345 5873 +1528
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
udpatil
approved these changes
Dec 12, 2025
Collaborator
udpatil
left a comment
There was a problem hiding this comment.
LGTM, doesn't seem to be used in any alerting or common grafana dashboards
yzang2019
approved these changes
Dec 12, 2025
947b727 to
cf05171
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Drops the unused
totalCheckTxCountcounter from the mempool. This metric tracks the total number of transactions that the mempool asks the app to check.The figure isn't ever read, and I can't really think of a reason why we might ever want to use it, so I propose dropping it.
Testing performed to validate your change
make testsucceeds.