Skip to content

fix: mempool: enforce txBlacklisting for stupidly big txs#2590

Merged
arajasek merged 1 commit intomainfrom
asr/fix-checkTx-blacklist
Dec 16, 2025
Merged

fix: mempool: enforce txBlacklisting for stupidly big txs#2590
arajasek merged 1 commit intomainfrom
asr/fix-checkTx-blacklist

Conversation

@arajasek
Copy link
Copy Markdown
Contributor

Describe your changes and provide context

This PR:

  • changes mempool config to have CheckTxErrorBlacklistEnabled true by default
  • weakens blacklist protection to apply to only oversized transactions.

Future PRs will expand blacklist protection to cover other forms of "clearly bad" transactions, such as:

  • undecodeable transactions
  • incorrect signatures
  • ludicrous params (more gas than a block has)
  • etc.

Testing performed to validate your change

make test passes

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 10, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedDec 16, 2025, 5:45 PM

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 43.22%. Comparing base (2f2a636) to head (ece4ece).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sei-tendermint/internal/mempool/mempool.go 90.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2590      +/-   ##
==========================================
- Coverage   43.22%   43.22%   -0.01%     
==========================================
  Files        1857     1857              
  Lines      153120   153124       +4     
==========================================
- Hits        66184    66182       -2     
- Misses      81020    81022       +2     
- Partials     5916     5920       +4     
Flag Coverage Δ
sei-chain 41.93% <ø> (-0.01%) ⬇️
sei-cosmos 38.03% <ø> (+<0.01%) ⬆️
sei-db 69.06% <ø> (ø)
sei-ibc-go 55.96% <ø> (ø)
sei-tendermint 47.50% <90.00%> (-0.02%) ⬇️
sei-wasmd 42.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-tendermint/internal/mempool/mempool.go 67.78% <90.00%> (+0.05%) ⬆️

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sei-will sei-will self-requested a review December 10, 2025 16:48
@arajasek arajasek force-pushed the asr/fix-checkTx-blacklist branch 6 times, most recently from 65b654f to 57a51d3 Compare December 16, 2025 15:21
@arajasek arajasek enabled auto-merge (squash) December 16, 2025 17:44
@arajasek arajasek force-pushed the asr/fix-checkTx-blacklist branch from 57a51d3 to ece4ece Compare December 16, 2025 17:44
@arajasek arajasek merged commit 7c3df71 into main Dec 16, 2025
42 checks passed
@arajasek arajasek deleted the asr/fix-checkTx-blacklist branch December 16, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants