Skip to content

Add lock to protect SetPrices in price feeder#2595

Merged
stevenlanders merged 2 commits intomainfrom
steven/add-mutex-for-set-prices-in-oracle
Dec 11, 2025
Merged

Add lock to protect SetPrices in price feeder#2595
stevenlanders merged 2 commits intomainfrom
steven/add-mutex-for-set-prices-in-oracle

Conversation

@stevenlanders
Copy link
Copy Markdown
Contributor

@stevenlanders stevenlanders commented Dec 11, 2025

Describe your changes and provide context

  • set prices currently may not have been called by the time reads are attempted
  • this can cause a panic due to a race condition

Testing performed to validate your change

  • new unit test

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 11, 2025 •
edited
Loading

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedDec 16, 2025, 1:35 PM

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 11, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.25%. Comparing base (8ec3c40) to head (667e4a4).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2595      +/-   ##
==========================================
- Coverage   43.25%   43.25%   -0.01%     
==========================================
  Files        1850     1850              
  Lines      152294   152296       +2     
==========================================
- Hits        65875    65874       -1     
- Misses      80549    80551       +2     
- Partials     5870     5871       +1
Flag Coverage Δ
sei-chain 42.09% <100.00%> (+<0.01%) ⬆️
sei-cosmos 38.03% <ø> (ø)
sei-db 69.06% <ø> (ø)
sei-ibc-go 55.96% <ø> (ø)
sei-tendermint 47.51% <ø> (-0.02%) ⬇️
sei-wasmd 42.10% <ø> (ø)
sei-wasmvm 39.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
oracle/price-feeder/oracle/oracle.go 82.38% <100.00%> (+0.08%) ⬆️

... and 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

arajasek
arajasek approved these changes Dec 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 11, 2025
View reviewed changes
oracle/price-feeder/oracle/oracle.go

o.mtx.Lock()
o.prices = computedPrices
o.lastPriceSyncTS = time.Now()

Check warning

Code scanning / CodeQL

Calling the system time Warning

Calling the system time may be a possible source of non-determinism
masih
masih approved these changes Dec 11, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core eventloop of oracle needs some tuning knob to control the velocity of ticks, and perhaps parallelise things per provider?

All future improvements that hopefully we never need to make!
Thanks for getting this sorted so quickly @stevenlanders 🍻

@stevenlanders stevenlanders merged commit 24912e1 into main Dec 11, 2025
70 of 79 checks passed
@stevenlanders stevenlanders deleted the steven/add-mutex-for-set-prices-in-oracle branch December 11, 2025 18:25
@masih
Copy link
Copy Markdown
Collaborator

masih commented Dec 16, 2025

/backport

github-actions bot pushed a commit that referenced this pull request Dec 16, 2025
@stevenlanders @github-actions
Add lock to protect SetPrices in price feeder (#2595)
9a8a87c 
## Describe your changes and provide context
- set prices currently may not have been called by the time reads are
attempted
- this can cause a panic due to a race condition

## Testing performed to validate your change
- new unit test

(cherry picked from commit 24912e1)
@github-actions github-actions bot mentioned this pull request Dec 16, 2025
Merged
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 16, 2025

Successfully created backport PR for release/v6.3:

masih pushed a commit that referenced this pull request Dec 17, 2025
@github-actions @stevenlanders
Backport release/v6.3: Add lock to protect SetPrices in price feeder (
e65e81d 
#2616)

Backport of #2595 to `release/v6.3`.

Co-authored-by: Steven Landers <steven@seinetwork.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masih masih masih approved these changes

@arajasek arajasek arajasek approved these changes

@udpatil udpatil udpatil approved these changes

Assignees

No one assigned

Labels

backport release/v6.3 non-app-hash-breaking

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stevenlanders @masih @arajasek @udpatil @github-advanced-security