Skip to content

[giga] add executor interfaces for VM#2601

Merged
codchen merged 1 commit intomainfrom
tony/executor-interfaces
Dec 22, 2025
Merged

[giga] add executor interfaces for VM#2601
codchen merged 1 commit intomainfrom
tony/executor-interfaces

Conversation

@codchen
Copy link
Copy Markdown
Collaborator

@codchen codchen commented Dec 15, 2025

Describe your changes and provide context

EVM implementations roughly adopt the following paradigm:

some preprocessing
calls the VM
- the VM starts doing stuff internally
some postprocessing

This PR defines the interfaces for the calls the VM part. The goal is so that we can relatively easily swap out the VM without changes to the rest of the codebase.
It also defines the storage interface for preprocessing/postprocessing to use without worrying about the underlying storage implementation (which is VM-specific).

The PR also provides implementation of the interfaces by Geth and EVMC, but not storage interface implementation yet.

Testing performed to validate your change

no functional changes.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 15, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedDec 22, 2025, 3:44 AM

@github-actions
Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedDec 15, 2025, 9:40 AM

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.70%. Comparing base (531d17d) to head (0bd1bc9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
giga/executor/vm/evmc/vm.go 0.00% 12 Missing ⚠️
giga/executor/vm/geth/vm.go 0.00% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2601      +/-   ##
==========================================
- Coverage   43.70%   43.70%   -0.01%     
==========================================
  Files        1899     1901       +2     
  Lines      158894   158914      +20     
==========================================
+ Hits        69449    69457       +8     
- Misses      83039    83050      +11     
- Partials     6406     6407       +1     
Flag Coverage Δ
sei-chain 45.70% <0.00%> (+<0.01%) ⬆️
sei-cosmos 38.03% <ø> (ø)
sei-db 69.06% <ø> (ø)
sei-tendermint 47.48% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
giga/executor/vm/geth/vm.go 0.00% <0.00%> (ø)
giga/executor/vm/evmc/vm.go 0.00% <0.00%> (ø)

... and 19 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codchen codchen force-pushed the tony/executor-interfaces branch from f8d0585 to 9312af0 Compare December 16, 2025 02:59
@codchen codchen force-pushed the tony/executor-interfaces branch from 9312af0 to 0bd1bc9 Compare December 22, 2025 03:44
@codchen codchen merged commit 296bceb into main Dec 22, 2025
38 of 39 checks passed
@codchen codchen deleted the tony/executor-interfaces branch December 22, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants