[CON-143] fix: deflake TestRouter_dialPeer_Reject#2603
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2603 +/- ##
==========================================
- Coverage 45.83% 43.25% -2.58%
==========================================
Files 1183 1851 +668
Lines 101986 152771 +50785
==========================================
+ Hits 46741 66080 +19339
- Misses 51168 80816 +29648
- Partials 4077 5875 +1798
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
4bc58d5 to
7760c07
Compare
stevenlanders
approved these changes
Dec 15, 2025
pompon0
approved these changes
Dec 15, 2025
udpatil
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This test can flakily fail with the following error:
The issue is that the test only wants an EOF error to signal a connection being closed, but you can probably get a bunch of different errors. This PR weakens the fail condition to
utils.IgnoreCancel(err) == nil, matching the pattern we already have in TestRouter_AcceptPeers (see here).This PR also makes the same change to
TestRouter_EvictPeers, which might flake in a similar way.Testing performed to validate your change
make testpasses