[CON-145] fix: deflake TestNewAnyWithCustomTypeURLWithErrorNoAllocation#2604
Merged
[CON-145] fix: deflake TestNewAnyWithCustomTypeURLWithErrorNoAllocation#2604
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2604 +/- ##
==========================================
- Coverage 43.22% 43.22% -0.01%
==========================================
Files 1857 1857
Lines 153124 153124
==========================================
- Hits 66195 66188 -7
- Misses 81013 81019 +6
- Partials 5916 5917 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
stevenlanders
approved these changes
Dec 15, 2025
Contributor
stevenlanders
left a comment
There was a problem hiding this comment.
That's cool! I didn't know about testing.AllocsPerRun
2006c45 to
ee0554d
Compare
udpatil
approved these changes
Dec 16, 2025
ee0554d to
d96e73f
Compare
yzang2019
approved these changes
Dec 16, 2025
d96e73f to
3852b4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
MemStats and its returned HeapAlloc are inherently unreliable, so the test assertion here is always going to be flaky. I think
AllocsPerRunis the right testing tool to use for what we want here, it didn't flake upon being run 2000 times locally.